Skip to content

Fix WASI sleep impl - #65617

Merged
bors merged 1 commit into
rust-lang:masterfrom
newpavlov:patch-2
Oct 23, 2019
Merged

Fix WASI sleep impl#65617
bors merged 1 commit into
rust-lang:masterfrom
newpavlov:patch-2

Conversation

@newpavlov

@newpavlovnewpavlov commented Oct 20, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#65607

@sunfishcode
Is it fine to use 0 for the identifier field? What is this field used for?

@rust-highfive

rust-highfive commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2019
@cramertj

cramertj commented Oct 21, 2019

Copy link
Copy Markdown
Member

r? @alexcrichton

@sunfishcode

sunfishcode commented Oct 21, 2019

Copy link
Copy Markdown
Member

@newpavlov That identifier field is a historical artifact and isn't used by anything.

sunfishcode added a commit to sunfishcode/WASI that referenced this pull request Oct 21, 2019
@sunfishcode
Remove subscription_t's clock.identifier field.
b87f6fb
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
@sunfishcodesunfishcode mentioned this pull request Oct 21, 2019
Merged
@alexcrichton

alexcrichton commented Oct 22, 2019

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1e2b711 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2019
@newpavlov

newpavlov commented Oct 22, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@sunfishcode
Are there plans to remove this field eventually? I think at the very least it's worth to add a deprecation notice to the Core docs. Some kind of semantic versioning for the Core API would've been nice as well.

P.S.: Slightly relevant to introducing changes to the Core API: can you please take a look at #64434? Are there indeed plans to change fd_prestat_* functions?

@sunfishcode

sunfishcode commented Oct 22, 2019

Copy link
Copy Markdown
Member

@newpavlov I just submitted WebAssembly/WASI#125 to start the process to remove it :-). And yes, we have just established a versioning scheme.

Concerning #64434, yes, there are changes to the fd_prestat functions planned, including adding support for pre-opened files and other resources.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2019
@JohnTitor
Rollup merge ofrust-lang#65617- newpavlov:patch-2, r=alexcrichton
294269c
Fix WASI sleep impl
Closesrust-lang#65607@sunfishcode
Is it fine to use 0 for the `identifier` field? What is this field used for?
@JohnTitorJohnTitor mentioned this pull request Oct 22, 2019
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
@JohnTitor
Rollup merge ofrust-lang#65617- newpavlov:patch-2, r=alexcrichton
ff2442f
Fix WASI sleep impl
Closesrust-lang#65607@sunfishcode
Is it fine to use 0 for the `identifier` field? What is this field used for?
@JohnTitorJohnTitor mentioned this pull request Oct 23, 2019
Merged
bors added a commit that referenced this pull request Oct 23, 2019
@bors
Auto merge of#65716- JohnTitor:rollup-fkcr85k, r=JohnTitor
f466f52
Rollup of 14 pull requests
Successful merges:
- #64145 (Target-feature documented as unsafe)
- #65007 (Mention keyword closing policy)
- #65417 (Add more coherence tests)
- #65507 (Fix test style in unused parentheses lint test)
- #65591 (Add long error explanation for E0588)
- #65617 (Fix WASI sleep impl)
- #65656 (Add option to disable keyboard shortcuts in docs)
- #65678 (Add long error explanation for E0728)
- #65681 (Code cleanups following up on #65576.)
- #65686 (refactor and move `maybe_append` )
- #65688 (Add some tests for fixed ICEs)
- #65689 (bring back some Debug instances for Miri)
- #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)
- #65706 (Add missing space in librustdoc)
Failed merges:
r? @ghost
@bors
bors merged commit 1e2b711 into rust-lang:masterOct 23, 2019
@newpavlov
newpavlov deleted the patch-2 branch October 23, 2019 13:53
sunfishcode added a commit to WebAssembly/WASI that referenced this pull request Oct 31, 2019
@sunfishcode
Removesubscription_t'sclock.identifierfield. (#125)
f5d6ef0
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
yoshuawuyts pushed a commit to yoshuawuyts/WASI that referenced this pull request Nov 25, 2025
@sunfishcode
Removesubscription_t'sclock.identifierfield. (WebAssembly#125)
0e019c6
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
yoshuawuyts pushed a commit to yoshuawuyts/WASI that referenced this pull request Nov 25, 2025
@sunfishcode
Removesubscription_t'sclock.identifierfield. (WebAssembly#125)
df8382b
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
yoshuawuyts pushed a commit to yoshuawuyts/WASI that referenced this pull request Nov 25, 2025
@sunfishcode
Removesubscription_t'sclock.identifierfield. (WebAssembly#125)
e854b5a
As noticed in
rust-lang/rust#65617 (comment),
the `clock.identifier` field in `subscription_t` isn't used for
anything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WASI target: thread::sleep() is panicing: unexpected result of poll_oneoff

6 participants

@newpavlov@rust-highfive@cramertj@sunfishcode@alexcrichton@bors