Uh oh!
There was an error while loading. Please reload this page.
[analysis][NFC] Refactor lattice unit tests - #6065
Merged
Merged
Conversation
This was referenced Oct 31, 2023
MemberAuthor
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
tlivelyforce-pushed
the
refactor-lattice-gtest
branch
from
October 31, 2023 00:35
1226fba to
518957fComparetlivelyforce-pushed
the
refactor-lattice-gtest
branch
from
October 31, 2023 17:39
518957f to
e8e0ab4Comparekripken
approved these changes
Oct 31, 2023
tlivelyforce-pushed
the
refactor-lattice-gtest
branch
from
November 1, 2023 01:19
e8e0ab4 to
f65d8a0CompareMany of the lattice tests were essentially copy-pasted from one lattice to the next because they all tested isomorphic subsets of the various lattices, specifically in the shape of a diamond. Refactor the code so that all lattices that have tests of this shape use the same utility test functions.
tlivelyforce-pushed
the
refactor-lattice-gtest
branch
from
November 1, 2023 17:16
f65d8a0 to
3e6b7ddCompareradekdoulik pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Many of the lattice tests were essentially copy-pasted from one lattice to the next because they all tested isomorphic subsets of the various lattices, specifically in the shape of a diamond. Refactor the code so that all lattices that have tests of this shape use the same utility test functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the lattice tests were essentially copy-pasted from one lattice to the
next because they all tested isomorphic subsets of the various lattices,
specifically in the shape of a diamond. Refactor the code so that all lattices
that have tests of this shape use the same utility test functions.