Uh oh!
There was an error while loading. Please reload this page.
[analysis] Simplify the stack lattice - #6069
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
| return NO_RELATION; | ||
| } | ||
| result = GREATER; | ||
| continue; |
There was a problem hiding this comment.
This switch sure looks familiar now... 🤔
There was a problem hiding this comment.
Maaaaybe it makes sense to try to share the switch logic. Note that everything surrounding the switch is slightly different in every case, though. (And in the tuple case, the switch contains recursive calls instead of continues.)
24bbc38 to
7f56796Compare7f56796 to
456aa3cComparekripken
commented
Nov 1, 2023
I only see one commit, so I'm not sure what changed since I approved this? Skimming it I don't see anything obviously different, and I didn't ask for changes? |
tlively
commented
Nov 1, 2023
The command I used to push and open #6069 must have re-requested review on this. Sorry for the noise! |
456aa3c to
350ba10CompareRemove the ability to represent the top element of the stack lattice since it isn't necessary. Also simplify the element type to be a simple vector, update the lattice method implementations to be more consistent with implementations in other lattices, and make the tests more consistent with the tests for other lattices.
350ba10 to
838bfacCompareRemove the ability to represent the top element of the stack lattice since it isn't necessary. Also simplify the element type to be a simple vector, update the lattice method implementations to be more consistent with implementations in other lattices, and make the tests more consistent with the tests for other lattices.
Remove the ability to represent the top element of the stack lattice since it
isn't necessary. Also simplify the element type to be a simple vector, update
the lattice method implementations to be more consistent with implementations in
other lattices, and make the tests more consistent with the tests for other
lattices.