Update extended const in features.json - #285
Merged
Merged
Conversation
dschuff
reviewed
Sep 30, 2022
| "bigInt": true, | ||
| "bulkMemory": true, | ||
| "exceptions": ["flag", "Requires flag `--experimental-wasm-eh`"], | ||
| "extendedConstantExprs": ["flag", "Requires flag `--experimental-wasm-extended-const`"], |
Member
There was a problem hiding this comment.
This is a JS flag, right? Not a Chrome flag? I think it needs to be wrapped in --js-flags=
Member
There was a problem hiding this comment.
(Also we should check whether it's enabled by the #enable-experimental-webassembly-features flag in chrome). That would be more convenient than requiring actual command-line switches.
Member
Author
There was a problem hiding this comment.
This is the Node section.. so that --js-flags things is not needed.
sbc100
force-pushed
the
extended_const
branch
from
September 30, 2022 18:56
66894b6 to
94b6464
Compare
sbc100
commented
Sep 30, 2022
| "bigInt": "85", | ||
| "bulkMemory": "75", | ||
| "exceptions": "95", | ||
| "extendedConstantExprs": ["flag", "Requires flag `--js-flags=--experimental-wasm-extended-const`"], |
Member
Author
There was a problem hiding this comment.
Confirmed that #enable-experimental-webassembly-features does not work here.
dschuff
approved these changes
Sep 30, 2022
Member
Author
|
Does this website auto-publish somehow? |
Member
|
Yeah it seems to be updated already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.