Conversation
I'm hoping to get extended-const support but there are other new detectors too I think.
| function _loadTooltipModule() { | ||
| // Be sure to change the preloads in markdown when updating url. | ||
| // The ESM bundle of this package doesn't work with unpkg.com. | ||
| const module = import('https://cdn.jsdelivr.net/npm/@floating-ui/dom@1/+esm'); |
There was a problem hiding this comment.
does the "1" here mean "1.0" (i.e. pinned to an older revision) or does it mean "get me the latest 1.x version"?
There was a problem hiding this comment.
No idea.. I just verified that the 1 didn't give me the new version that I wanted and 1.3 did.
There was a problem hiding this comment.
@RReverser is this the correctly thing to do here?
There was a problem hiding this comment.
does the "1" here mean "1.0" (i.e. pinned to an older revision) or does it mean "get me the latest 1.x version"?
I honestly don't know; before #283 we used unpkg.com where it wouldn't be pinned, but I'm not very familiar with what jsdelivr does.
Explicitly bumping to 1.3 sounds good.
There was a problem hiding this comment.
That said, https://cdn.jsdelivr.net/npm/@floating-ui/dom@1.3/+esm doesn't seem to work?
There was a problem hiding this comment.
Wait, I don't think this is a module you meant to bump at all. This is not wasm-feature-detect, it's just a tooltip library.
There was a problem hiding this comment.
Ooops! Wrong URL.
Actually I noticed that the existing URL seems to fetch 1.3 already: https://cdn.jsdelivr.net/npm/wasm-feature-detect@1/dist/esm/index.js
So I'm closing this..
There was a problem hiding this comment.
Just to clarify @1 will load the latest 1.x.x version https://github.com/jsdelivr/jsdelivr#npm
The HTTP headers also verify it:
x-jsd-version: 1.3.0
x-jsd-version-type: version
|
Bumped the correct library in 2d5bcb9 instead. |
|
Ooop, sorry for the noise. It seem that maybe this wan't needed? |
|
Anyway looks like the new detector for extended const is online and working as intended! |
|
I think it still was - it's a bit scary because Better to be semver-explicit. |
Are there browsers where it works for you? If it's available under a flag in some browsers already, we should reflect that in features.json. |
|
Looks like we did have it before: https://github.com/WebAssembly/website/blob/master/features.json#L97 Here and in other browsers the feature needs to be renamed as well now. |
|
Yes, it works in chrome with flag, I added that in #285, but it looks like I need another update because I called it |
I'm hoping to get extended-const support but there are other new detectors too I think.