Skip to content

Bump version of wasm-feature-detect #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbc100 wants to merge 1 commit into from
+1 −1
Closed

Bump version of wasm-feature-detect #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roadmap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@
function _loadTooltipModule() {
// Be sure to change the preloads in markdown when updating url.
// The ESM bundle of this package doesn't work with unpkg.com.
const module = import('https://cdn.jsdelivr.net/npm/@floating-ui/dom@1/+esm');

@dschuff dschuff Oct 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the "1" here mean "1.0" (i.e. pinned to an older revision) or does it mean "get me the latest 1.x version"?

@sbc100 sbc100 Oct 3, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea.. I just verified that the 1 didn't give me the new version that I wanted and 1.3 did.

@sbc100 sbc100 Oct 3, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RReverser is this the correctly thing to do here?

@RReverser RReverser Oct 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the "1" here mean "1.0" (i.e. pinned to an older revision) or does it mean "get me the latest 1.x version"?

I honestly don't know; before #283 we used unpkg.com where it wouldn't be pinned, but I'm not very familiar with what jsdelivr does.

Explicitly bumping to 1.3 sounds good.

@RReverser RReverser Oct 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, https://cdn.jsdelivr.net/npm/@floating-ui/dom@1.3/+esm doesn't seem to work?

@RReverser RReverser Oct 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I don't think this is a module you meant to bump at all. This is not wasm-feature-detect, it's just a tooltip library.

@sbc100 sbc100 Oct 4, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops! Wrong URL.

Actually I noticed that the existing URL seems to fetch 1.3 already: https://cdn.jsdelivr.net/npm/wasm-feature-detect@1/dist/esm/index.js

So I'm closing this..

@jimaek jimaek Oct 5, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify @1 will load the latest 1.x.x version https://github.com/jsdelivr/jsdelivr#npm
The HTTP headers also verify it:

x-jsd-version: 1.3.0
x-jsd-version-type: version

const module = import('https://cdn.jsdelivr.net/npm/@floating-ui/dom@1.3/+esm');

const subscribers = new Set();
const updateAll = () => { for (const fn of subscribers) fn(); };
Expand Down