Fixing HLS playback. by valbok · Pull Request #16 · WebPlatformForEmbedded/WPEWebKit

valbok · 2015-12-18T14:17:48Z

Fixed following:

Fixed to set infinity duration to MediaSourceClientGStreamerMSE. See SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment. When no valid duration found in Initialization Segment Received it sets infinity as a duration and makes it as a live stream.
In case if current duration is infinity in MediaPlayerPrivateGStreamerMSE::maxTimeSeekable() added a fix to fetch the highest end time value from buffered attribute to return proper filled TimeRange object in HTMLMediaElement.seekable().
Fixed MediaSource::monitorSourceBuffers() to prevent assigning HAVE_ENOUGH_DATA to media player which led to send loadeddata event before initialization segment received, and no valid duration, seekable and other attributes returned.

eocanha · 2015-12-21T13:19:13Z

The changes are fine. Just rebase them against the latest master and squash the three commits in one ("git rebase -i", change "push" for "s" in all the commits except the first one, write a meaningful message) and we're done.

valbok · 2015-12-21T14:28:42Z

Hi Enrique, sorry about messup with commits, please say if there is an additional need to prepare the fix.

valbok · 2016-01-11T12:08:23Z

Hi Enrique, please merge last changes, that was somehow missing from previous merge. Thanks

philn · 2016-01-11T12:09:47Z

What do you mean by HLS? Apple's HLS is usually handled with the standard player in WebKit (not MSE).

valbok · 2016-01-11T12:23:54Z

philn, http live streaming.
We were experiencing problems to play http://chenz.org/flowplayer-hls-live-example.html and MSE was used there.

Last commit also contains serious fix in MediaSource::monitorSourceBuffers() to prevent assigning HAVE_ENOUGH_DATA to media player.
And an ability to assign positive infinite duration to define it as "live stream".

philn · 2016-01-11T12:28:06Z

Ah ok, so that player implements HLS with MSE, for the unlucky browsers not supporting it natively :)

eocanha · 2016-01-11T18:40:57Z

Sorry, I can't merge the pull request because it causes YouTube 2016 tests 23 and 42 to fail.

Fixed following: 1. Fixed to set infinity duration to MediaSourceClientGStreamerMSE. See SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment. When no valid duration found in Initialization Segment Received it sets infinity as a duration and makes it as a live stream. 2. In case if current duration is infinity in MediaPlayerPrivateGStreamerMSE::maxTimeSeekable() added a fix to fetch the highest end time value from buffered attribute to return proper filled TimeRange object in HTMLMediaElement.seekable(). 3. Fixed MediaSource::monitorSourceBuffers() to prevent assigning HAVE_ENOUGH_DATA to media player which led to send loadeddata event before initialization segment received, and no valid duration, seekable and other attributes returned.

valbok · 2016-01-22T16:20:06Z

Hi Enrique, could you please check my latest fixes, that should fix 23 youtube test from http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html. Also potentially may fix 42 - MediaSourceDuration.

FYI: 23 test failed due to following change:
031465c#diff-1a0340714c802e905fa36d804906e36eR659

Because I allowed to pass inf value to MediaSourceClient and MediaPlayerPrivateGStreamerMSE.
Right now after this fix durationMediaTime() is responsible to return always correct value: means 0 is correct value, inf is not. Instead of inf buffered time will be returned.

Since previously player never had infinite duration, looks durationMediaTime() is not supposed to and should not return inf value as well.

valbok · 2016-01-26T10:44:10Z

@albertd, could you please tip how to build and test MSE on the Pi? link? Thanks

valbok · 2016-01-26T10:54:36Z

Thanks, but I meant build and run WebKitForWayland on the Pi.

sarkanyi · 2016-09-20T14:34:27Z

I think I might have a more elegant and non-breaking solution for your issue, please see here:
sarkanyi@389a2a9

…s and zero reg https://bugs.webkit.org/show_bug.cgi?id=168527 Reviewed by Filip Pizlo. Added support for data processing 1 source instructions like rbit, rev, clz and cls. Added support for the FP conditional select instruction, fcsel. Consolidated the two classes for handling dmb instructions into one class. Fixed the instruction selection mask in the integer conditional select class, A64DOpcodeConditionalSelect. Fixed the processing of extract instruction (extr) including the rotate right (ror) pseudo instruction. Changed the printing of x31 and w31 to xzr and wzr as operands according to the spec. Added support for common pseudo instructions. This includes: - mvn x1, X2 in place of orn x1, xzr, x2 - lsl x3, x4, #count in place of ubfiz x3, x4, #count, #count - smull x5, w6, w7 in place of smaddl x5, w6, w7, XZR - More understandable mov x8, #-304 in place of movn x8, #0x12f - Eliminated xzr from register index loads and stores, outputing ldr x10, [x11] instead of ldr x10, [x11, xzr] Changed the move wide instructions to use hex literals for movz and movk. This makes it much easier to decifer sequences of wide moves for large literals. Before After movz x17, #26136 movz x17, #0x6618 movk x17, #672, lsl #16 movk x17, #0x2a0, lsl #16 movk x17, #1, lsl #32 movk x17, #0x1, lsl #32 Verified that all instructions currently generated by the JSC stress tests are disassembled. * disassembler/ARM64/A64DOpcode.cpp: (JSC::ARM64Disassembler::A64DOpcodeBitfield::format): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing1Source::format): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing2Source::format): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing3Source::format): (JSC::ARM64Disassembler::A64DOpcodeExtract::format): (JSC::ARM64Disassembler::A64DOpcodeFloatingPointConditionalSelect::format): (JSC::ARM64Disassembler::A64DOpcodeFloatingPointIntegerConversions::format): (JSC::ARM64Disassembler::A64DOpcodeDmb::format): (JSC::ARM64Disassembler::A64DOpcodeLoadStoreImmediate::format): (JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterOffset::format): (JSC::ARM64Disassembler::A64DOpcodeLoadStoreRegisterPair::format): (JSC::ARM64Disassembler::A64DOpcodeLoadStoreUnsignedImmediate::format): (JSC::ARM64Disassembler::A64DOpcodeLogicalShiftedRegister::format): (JSC::ARM64Disassembler::A64DOpcodeMoveWide::format): (JSC::ARM64Disassembler::A64DOpcodeDmbIsh::format): Deleted. (JSC::ARM64Disassembler::A64DOpcodeDmbIshSt::format): Deleted. * disassembler/ARM64/A64DOpcode.h: (JSC::ARM64Disassembler::A64DOpcode::appendSignedImmediate64): (JSC::ARM64Disassembler::A64DOpcode::appendUnsignedHexImmediate): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing1Source::opName): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing1Source::sBit): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing1Source::opCode): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing1Source::opCode2): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing1Source::opNameIndex): (JSC::ARM64Disassembler::A64DOpcodeDataProcessing3Source::opName): (JSC::ARM64Disassembler::A64DOpcodeFloatingPointConditionalSelect::opName): (JSC::ARM64Disassembler::A64DOpcodeFloatingPointConditionalSelect::condition): (JSC::ARM64Disassembler::A64DOpcodeDmb::option): (JSC::ARM64Disassembler::A64DOpcodeDmb::crM): (JSC::ARM64Disassembler::A64DOpcodeLogicalShiftedRegister::isMov): (JSC::ARM64Disassembler::A64DOpcodeDmbIsh::opName): Deleted. (JSC::ARM64Disassembler::A64DOpcodeDmbIshSt::opName): Deleted. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@212592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

albertd assigned eocanha Dec 18, 2015

valbok force-pushed the master branch 2 times, most recently from 4fda158 to 2d52cc1Compare December 24, 2015 15:51

valbok force-pushed the master branch 3 times, most recently from ddb3e01 to 20b7e2aCompare January 11, 2016 12:04

valbok force-pushed the master branch from 20b7e2a to 89232f2Compare January 22, 2016 16:06

philn force-pushed the master branch 2 times, most recently from b4a4f67 to 3f4ede2Compare June 17, 2016 13:48

valbok closed this Nov 15, 2016

aazamansari mentioned this pull request Dec 28, 2016
Thread leak during clean up #165
Closed

GlebNovodranPE mentioned this pull request Apr 25, 2017
Fix for the "ThreadedCompositor crash on exit" problem #258
Merged

aazamansari mentioned this pull request Jun 5, 2017
Crash in JavascriptCore #290
Closed

aazamansari mentioned this pull request Jul 14, 2017
JSC Crash in operationLinkDirectCall #327
Closed

aazamansari mentioned this pull request Aug 22, 2017
WPEWebProcess Crash in SpaceSplitString.h #359
Closed

Balajims88 mentioned this pull request Oct 27, 2017
fix for crashes during auto switch of videos in YouTube #393
Merged

nrajan002c mentioned this pull request Jan 2, 2018
Webprocess is hanged (Deadlock) in parkConditionallyImpl #430
Closed

nrajan002c mentioned this pull request Sep 27, 2018
Crash in heapDecreaseKey() #539
Closed

Gavriliuk mentioned this pull request Apr 23, 2019
JSC Crash in revertCall executed from unlinkFor #597
Closed

kkanag314 mentioned this pull request Nov 19, 2020
WPEWebProcess crash (JavaScriptCore) due to SIGFPE #686
Closed

ManjariMallikarjun mentioned this pull request Feb 4, 2021
WPEWebProcess crashes on every alternate launch of lightening App #695
Closed

varumugam123 mentioned this pull request Feb 4, 2021
Crash with operator() symbol during long Hulu / YouTube video playbacks #696
Closed

This was referenced Mar 30, 2021
WPEWebProcess crash with signature ~RecordedStatuses due to SIGABRT #703
Closed
WPEWebProcess crash in createResolve #704
Closed
WPEWebProcess crash with signature resolveRopeSlowCase8 due to SIGSEGV #705
Closed

zbigniew-holdys-epam mentioned this pull request Nov 25, 2021
WPEWebProcess is crashing when access Wikipedia OTT app #749
Closed

asurdej-comcast mentioned this pull request Aug 2, 2023
Wpe-2.38 Deadlock in WebKitMediaSrc (PrimeVideo) #1135
Closed

tomasz-karczewski-red mentioned this pull request Aug 7, 2024
problems with GC memory reclamation on wpe 2.38 #1363
Open

Navigation Menu

Uh oh!

Fixing HLS playback. - #16

Fixing HLS playback.#16
valbok wants to merge 1 commit into
WebPlatformForEmbedded:masterfrom
valbok:master

valbok commented Dec 18, 2015

Uh oh!

eocanha commented Dec 21, 2015

Uh oh!

valbok commented Dec 21, 2015

Uh oh!

valbok commented Jan 11, 2016

Uh oh!

philn commented Jan 11, 2016

Uh oh!

valbok commented Jan 11, 2016

Uh oh!

philn commented Jan 11, 2016

Uh oh!

eocanha commented Jan 11, 2016

Uh oh!

valbok commented Jan 22, 2016

Uh oh!

valbok commented Jan 26, 2016

Uh oh!

valbok commented Jan 26, 2016

Uh oh!

sarkanyi commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

valbok commented Dec 18, 2015

Uh oh!

eocanha commented Dec 21, 2015

Uh oh!

valbok commented Dec 21, 2015

Uh oh!

valbok commented Jan 11, 2016

Uh oh!

philn commented Jan 11, 2016

Uh oh!

valbok commented Jan 11, 2016

Uh oh!

philn commented Jan 11, 2016

Uh oh!

eocanha commented Jan 11, 2016

Uh oh!

valbok commented Jan 22, 2016

Uh oh!

valbok commented Jan 26, 2016

Uh oh!

valbok commented Jan 26, 2016

Uh oh!

sarkanyi commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants