Skip to content

[MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evic… - #296

Merged
eocanha merged 1 commit into
WebPlatformForEmbedded:masterfrom
vertexodessa:quota
Jun 21, 2017
Merged

[MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evic…#296
eocanha merged 1 commit into
WebPlatformForEmbedded:masterfrom
vertexodessa:quota

Conversation

@vertexodessa

Copy link
Copy Markdown

…table data in Source Buffer

#286

@zdobersek
zdobersek requested a review from eocanhaJune 20, 2017 12:47
@eocanha

Copy link
Copy Markdown
Member

I'm assuming that the main use case of this change is this one (example):

  • You have "[0,10]; [50, 60]" buffered (from previous appends)
  • You seek to 40, so currentTime is 40
  • You append "[40, 50]"
  • Now you have "[0, 10]; [40, 60]", m_groupEndTimestamp is 50 (the limit you've just appended) and currentTime belongs to the last buffered interval.

This patch would allow the removal of [50, 60]. An interval which would probably be appended again by JavaScript.

If that's right, then the patch looks good. I still have to test it against the tests and with YouTube.

@vertexodessa

vertexodessa commented Jun 21, 2017

Copy link
Copy Markdown
Author

well, the patch is trying to solve the following:

  • you have [200, 1000) buffered and the buffer is almost full
  • you seek to 195
  • JS appends [195, 200)
  • at this point, [195, 1000) is buffered and the buffer is full
  • JS tries to append unparsed data (it's for [200, 205) but we don't know this yet) but the buffer is full and we get an exception

@eocanha
eocanha merged commit a4cc739 into WebPlatformForEmbedded:masterJun 21, 2017
vertexodessa added a commit to vertexodessa/WebKitForWayland that referenced this pull request Jun 26, 2017
eocanha pushed a commit that referenced this pull request Jun 27, 2017
charlie-ht added a commit that referenced this pull request Sep 11, 2017
Commits merged,
[MSE] Fix BufUnbuf test from YouTube's MSE conformance test suite
06b35a8
[MSE] Improve SourceBuffer::appendBuffer() time
e5b8d88
[MSE] Improve perfomance of SourceBuffer::evictCodedFrames
ce724e5
[MSE] fix calculation of MediaSource::currentTimeFudgeFactor
26a5288
Cap the reported progress of implicit animations
7162d05
[MSE] Fix unsigned comparison warning.
aec09ae
[GStreamer][MSE] Make setAppendState thread safe
4508db9
[WPE] Enable MEMORY_SAMPLER
26614e8
Revert "[GStreamer][MSE] Add missing lock around getStreamByTrackId"
aaab302
Use the return value of gst_mini_object_make_writable...
b4df1c5
webbrige sets WPE_RAM_SIZE to 128M, which tickles a logic error in
the cache model.
066c52b
Fixed UI issues in webinspector
b0e7fd8
Fix for issue #326 WebInspector-Popover
9cbbdd7
[WPEWebkit] Added support for ARMV8 processor.
d3a3365
[GStreamer] Fix video resize problems after quality change
b2ce7dc
Fix for PageUp/PageDown keys
29c10d9
[Gstreamer] Make sure live stream is detected
ef9a398
Fix for WebInspector-NetworkTab
71d0d30
[GStreamer] Fix for invalid video size information sometimes returned by getVideoSizeAndFormatFromCaps (gst_video_info_from_caps)
59fbb57
[GStreamer] Make volume control consistent
939aa76
[MSE][GStreamer] Fix premature video clip change on youtube
8dfa02e
[GStreamer][MSE] Don't flush audio streams, only video streams
148ffdd
Fixed bug with unneeded rangeRemoval
25c3dd3
[MSE][GStreamer] don't pause playback when there is enough data
9842bc6
[MSE][GStreamer] increase the playback buffer size
72a5ffc
Fixed UI issues in webinspector
3f777e3
Fix for wpe PageClient overrides
5000203
Fixed MediaElementsEvents test
97c32be
[MSE][GStreamer] Fix infinite loop in evictCodedFrames() when duration is infinite
c11d0d4
Fixed typo indefiniteTime -> isIndefinite (#306)
a4cc739
[MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evictable data in Source Buffer (#296)
eec35dd
minor compile errors [sic]
d392c15
volume method wrapped with WPE, usage is not
4e9b1cf
Add a METROLOGICAL define to be able to ifdef pieces of code specific to downstream WPE
fdac418
Implemented custom headers per url
21f3896
Made fudge factor for audio a fraction
c527870
Fix MSE video size test failures (#276) (#277)
277e5de
[GStreamer][MSE] Reject too big channels/framerate/width/height mime type values
Commits we might want but that conflict heavily or seem N/A.
254e68d
Make scroll-to-focused-element behaviour configurable.
d608ad3
Add <functional> header for std::functional
758f885
Fixed bug with wrong expires date in cookies
11727e2
[MSE][GStreamer] keep the ahead buffer when evicting coded frames
7fb21a9
[GStreamer][MSE] Fix stall in seek to end of buffered range
3cd4d31
[GStreamer][MSE] Fix stall in seek due to incomplete reenqueue
b407c23 WKView: add a wpe_view_backend getter.
c99d5ee
[GStreamer] Notify player private (PlatformLayer) destruction to the
d9f7dc6
Fix-for-delay-in-web-audio
06ff542
Generalise DB410c switch
427b052
[MSE] Don't try to adopt a floater.
259e898
Fix for 302 Redirect support (#356)
4e778b5
[WebInspector] Fix for elements page, use getPropertyValue instead of discontinued getPropertyCSSValue
313ff46
Add platform variable for DB410c
f017f70
Using optimised vsink for platform DB410C
9a02007
[GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer
5674f3b
[GStreamer][WebAudio] Avoid sending null data/silence
83a08d0
Add a page property for enabling console log with private browsing
e2c897e
Use -ffunction-sections/-fdata-sections/--gc-sections with clang too [where has this stuff gone?]
cad2f3c
Make Web Inspector Remote to listen on both IPv4 and IPv6 addresses
85504c3
Make the code inclusive of musl when OS is linux
ae1b1e5
Use a setting to disable scrolling to the keyboard focused element instead of an env variable.
@charlie-htcharlie-ht mentioned this pull request Sep 11, 2017
charlie-ht added a commit that referenced this pull request Sep 13, 2017
Commits merged,
[MSE] Fix BufUnbuf test from YouTube's MSE conformance test suite
06b35a8
[MSE] Improve SourceBuffer::appendBuffer() time
e5b8d88
[MSE] Improve perfomance of SourceBuffer::evictCodedFrames
ce724e5
[MSE] fix calculation of MediaSource::currentTimeFudgeFactor
26a5288
Cap the reported progress of implicit animations
7162d05
[MSE] Fix unsigned comparison warning.
aec09ae
[GStreamer][MSE] Make setAppendState thread safe
4508db9
[WPE] Enable MEMORY_SAMPLER
26614e8
Revert "[GStreamer][MSE] Add missing lock around getStreamByTrackId"
aaab302
Use the return value of gst_mini_object_make_writable...
b4df1c5
webbrige sets WPE_RAM_SIZE to 128M, which tickles a logic error in
the cache model.
066c52b
Fixed UI issues in webinspector
b0e7fd8
Fix for issue #326 WebInspector-Popover
9cbbdd7
[WPEWebkit] Added support for ARMV8 processor.
d3a3365
[GStreamer] Fix video resize problems after quality change
b2ce7dc
Fix for PageUp/PageDown keys
29c10d9
[Gstreamer] Make sure live stream is detected
ef9a398
Fix for WebInspector-NetworkTab
71d0d30
[GStreamer] Fix for invalid video size information sometimes returned by getVideoSizeAndFormatFromCaps (gst_video_info_from_caps)
59fbb57
[GStreamer] Make volume control consistent
939aa76
[MSE][GStreamer] Fix premature video clip change on youtube
8dfa02e
[GStreamer][MSE] Don't flush audio streams, only video streams
148ffdd
Fixed bug with unneeded rangeRemoval
25c3dd3
[MSE][GStreamer] don't pause playback when there is enough data
9842bc6
[MSE][GStreamer] increase the playback buffer size
72a5ffc
Fixed UI issues in webinspector
3f777e3
Fix for wpe PageClient overrides
5000203
Fixed MediaElementsEvents test
97c32be
[MSE][GStreamer] Fix infinite loop in evictCodedFrames() when duration is infinite
c11d0d4
Fixed typo indefiniteTime -> isIndefinite (#306)
a4cc739
[MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evictable data in Source Buffer (#296)
eec35dd
minor compile errors [sic]
d392c15
volume method wrapped with WPE, usage is not
4e9b1cf
Add a METROLOGICAL define to be able to ifdef pieces of code specific to downstream WPE
fdac418
Implemented custom headers per url
21f3896
Made fudge factor for audio a fraction
c527870
Fix MSE video size test failures (#276) (#277)
277e5de
[GStreamer][MSE] Reject too big channels/framerate/width/height mime type values
Commits we might want but that conflict heavily or seem N/A.
254e68d
Make scroll-to-focused-element behaviour configurable.
d608ad3
Add <functional> header for std::functional
758f885
Fixed bug with wrong expires date in cookies
11727e2
[MSE][GStreamer] keep the ahead buffer when evicting coded frames
7fb21a9
[GStreamer][MSE] Fix stall in seek to end of buffered range
3cd4d31
[GStreamer][MSE] Fix stall in seek due to incomplete reenqueue
b407c23 WKView: add a wpe_view_backend getter.
c99d5ee
[GStreamer] Notify player private (PlatformLayer) destruction to the
d9f7dc6
Fix-for-delay-in-web-audio
06ff542
Generalise DB410c switch
427b052
[MSE] Don't try to adopt a floater.
259e898
Fix for 302 Redirect support (#356)
4e778b5
[WebInspector] Fix for elements page, use getPropertyValue instead of discontinued getPropertyCSSValue
313ff46
Add platform variable for DB410c
f017f70
Using optimised vsink for platform DB410C
9a02007
[GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer
5674f3b
[GStreamer][WebAudio] Avoid sending null data/silence
83a08d0
Add a page property for enabling console log with private browsing
e2c897e
Use -ffunction-sections/-fdata-sections/--gc-sections with clang too [where has this stuff gone?]
cad2f3c
Make Web Inspector Remote to listen on both IPv4 and IPv6 addresses
85504c3
Make the code inclusive of musl when OS is linux
ae1b1e5
Use a setting to disable scrolling to the keyboard focused element instead of an env variable.
charlie-ht added a commit that referenced this pull request Sep 14, 2017
* Merge master into staging.
Commits merged,
[MSE] Fix BufUnbuf test from YouTube's MSE conformance test suite
06b35a8
[MSE] Improve SourceBuffer::appendBuffer() time
e5b8d88
[MSE] Improve perfomance of SourceBuffer::evictCodedFrames
ce724e5
[MSE] fix calculation of MediaSource::currentTimeFudgeFactor
26a5288
Cap the reported progress of implicit animations
7162d05
[MSE] Fix unsigned comparison warning.
aec09ae
[GStreamer][MSE] Make setAppendState thread safe
4508db9
[WPE] Enable MEMORY_SAMPLER
26614e8
Revert "[GStreamer][MSE] Add missing lock around getStreamByTrackId"
aaab302
Use the return value of gst_mini_object_make_writable...
b4df1c5
webbrige sets WPE_RAM_SIZE to 128M, which tickles a logic error in
the cache model.
066c52b
Fixed UI issues in webinspector
b0e7fd8
Fix for issue #326 WebInspector-Popover
9cbbdd7
[WPEWebkit] Added support for ARMV8 processor.
d3a3365
[GStreamer] Fix video resize problems after quality change
b2ce7dc
Fix for PageUp/PageDown keys
29c10d9
[Gstreamer] Make sure live stream is detected
ef9a398
Fix for WebInspector-NetworkTab
71d0d30
[GStreamer] Fix for invalid video size information sometimes returned by getVideoSizeAndFormatFromCaps (gst_video_info_from_caps)
59fbb57
[GStreamer] Make volume control consistent
939aa76
[MSE][GStreamer] Fix premature video clip change on youtube
8dfa02e
[GStreamer][MSE] Don't flush audio streams, only video streams
148ffdd
Fixed bug with unneeded rangeRemoval
25c3dd3
[MSE][GStreamer] don't pause playback when there is enough data
9842bc6
[MSE][GStreamer] increase the playback buffer size
72a5ffc
Fixed UI issues in webinspector
3f777e3
Fix for wpe PageClient overrides
5000203
Fixed MediaElementsEvents test
97c32be
[MSE][GStreamer] Fix infinite loop in evictCodedFrames() when duration is infinite
c11d0d4
Fixed typo indefiniteTime -> isIndefinite (#306)
a4cc739
[MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evictable data in Source Buffer (#296)
eec35dd
minor compile errors [sic]
d392c15
volume method wrapped with WPE, usage is not
4e9b1cf
Add a METROLOGICAL define to be able to ifdef pieces of code specific to downstream WPE
fdac418
Implemented custom headers per url
21f3896
Made fudge factor for audio a fraction
c527870
Fix MSE video size test failures (#276) (#277)
277e5de
[GStreamer][MSE] Reject too big channels/framerate/width/height mime type values
Commits we might want but that conflict heavily or seem N/A.
254e68d
Make scroll-to-focused-element behaviour configurable.
d608ad3
Add <functional> header for std::functional
758f885
Fixed bug with wrong expires date in cookies
11727e2
[MSE][GStreamer] keep the ahead buffer when evicting coded frames
7fb21a9
[GStreamer][MSE] Fix stall in seek to end of buffered range
3cd4d31
[GStreamer][MSE] Fix stall in seek due to incomplete reenqueue
b407c23 WKView: add a wpe_view_backend getter.
c99d5ee
[GStreamer] Notify player private (PlatformLayer) destruction to the
d9f7dc6
Fix-for-delay-in-web-audio
06ff542
Generalise DB410c switch
427b052
[MSE] Don't try to adopt a floater.
259e898
Fix for 302 Redirect support (#356)
4e778b5
[WebInspector] Fix for elements page, use getPropertyValue instead of discontinued getPropertyCSSValue
313ff46
Add platform variable for DB410c
f017f70
Using optimised vsink for platform DB410C
9a02007
[GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer
5674f3b
[GStreamer][WebAudio] Avoid sending null data/silence
83a08d0
Add a page property for enabling console log with private browsing
e2c897e
Use -ffunction-sections/-fdata-sections/--gc-sections with clang too [where has this stuff gone?]
cad2f3c
Make Web Inspector Remote to listen on both IPv4 and IPv6 addresses
85504c3
Make the code inclusive of musl when OS is linux
ae1b1e5
Use a setting to disable scrolling to the keyboard focused element instead of an env variable.
* Fix style comments.
These are from calvaris and the check-webkit-style, ignoring all
warnings less than category level 5, because there's too many to fix
(and calvaris didn't notice most of them :))
* Fix more style issues.
The following is now silent,
./Tools/Scripts/check-webkit-style -g 90bc784..
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vertexodessa@eocanha