Uh oh!
There was an error while loading. Please reload this page.
Fix for 302 Redirect support - #356
Merged
Merged
Conversation
| } | ||
| if(response.isRedirected()) | ||
| priv->uri = g_strdup(response.url().string().utf8().data()); |
There was a problem hiding this comment.
You should also g_free() the previous value of priv->uri.
| return; | ||
| } | ||
| if(response.isRedirected()){ |
There was a problem hiding this comment.
OK this looks better. Just a spacing complaint: remember that in WebKit we leave a space after the if and before the {, like if (response.isRedirected()) {
| if(response.isRedirected()){ | ||
| g_free(priv->uri); | ||
| priv->uri = g_strdup(response.url().string().utf8().data()); |
There was a problem hiding this comment.
Do you need to check if urlHasSupportedProtocol(url) like in webKitWebSrcSetUri?
calvaris
approved these changes
Aug 23, 2017
calvaris
left a comment
Member
There was a problem hiding this comment.
This code has changed a lot upstream but I don't see anything wrong with it for master
estobbart pushed a commit
to estobbart/WPEWebKit
that referenced
this pull request
Sep 9, 2017
* Fix for 302 Redirect support * Updated fix for 302 redirect support * Added check for invalid redirect url
charlie-ht added a commit
that referenced
this pull request
Sep 11, 2017
Commits merged, [MSE] Fix BufUnbuf test from YouTube's MSE conformance test suite 06b35a8 [MSE] Improve SourceBuffer::appendBuffer() time e5b8d88 [MSE] Improve perfomance of SourceBuffer::evictCodedFrames ce724e5 [MSE] fix calculation of MediaSource::currentTimeFudgeFactor 26a5288 Cap the reported progress of implicit animations 7162d05 [MSE] Fix unsigned comparison warning. aec09ae [GStreamer][MSE] Make setAppendState thread safe 4508db9 [WPE] Enable MEMORY_SAMPLER 26614e8 Revert "[GStreamer][MSE] Add missing lock around getStreamByTrackId" aaab302 Use the return value of gst_mini_object_make_writable... b4df1c5 webbrige sets WPE_RAM_SIZE to 128M, which tickles a logic error in the cache model. 066c52b Fixed UI issues in webinspector b0e7fd8 Fix for issue #326 WebInspector-Popover 9cbbdd7 [WPEWebkit] Added support for ARMV8 processor. d3a3365 [GStreamer] Fix video resize problems after quality change b2ce7dc Fix for PageUp/PageDown keys 29c10d9 [Gstreamer] Make sure live stream is detected ef9a398 Fix for WebInspector-NetworkTab 71d0d30 [GStreamer] Fix for invalid video size information sometimes returned by getVideoSizeAndFormatFromCaps (gst_video_info_from_caps) 59fbb57 [GStreamer] Make volume control consistent 939aa76 [MSE][GStreamer] Fix premature video clip change on youtube 8dfa02e [GStreamer][MSE] Don't flush audio streams, only video streams 148ffdd Fixed bug with unneeded rangeRemoval 25c3dd3 [MSE][GStreamer] don't pause playback when there is enough data 9842bc6 [MSE][GStreamer] increase the playback buffer size 72a5ffc Fixed UI issues in webinspector 3f777e3 Fix for wpe PageClient overrides 5000203 Fixed MediaElementsEvents test 97c32be [MSE][GStreamer] Fix infinite loop in evictCodedFrames() when duration is infinite c11d0d4 Fixed typo indefiniteTime -> isIndefinite (#306) a4cc739 [MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evictable data in Source Buffer (#296) eec35dd minor compile errors [sic] d392c15 volume method wrapped with WPE, usage is not 4e9b1cf Add a METROLOGICAL define to be able to ifdef pieces of code specific to downstream WPE fdac418 Implemented custom headers per url 21f3896 Made fudge factor for audio a fraction c527870 Fix MSE video size test failures (#276) (#277) 277e5de [GStreamer][MSE] Reject too big channels/framerate/width/height mime type values Commits we might want but that conflict heavily or seem N/A. 254e68d Make scroll-to-focused-element behaviour configurable. d608ad3 Add <functional> header for std::functional 758f885 Fixed bug with wrong expires date in cookies 11727e2 [MSE][GStreamer] keep the ahead buffer when evicting coded frames 7fb21a9 [GStreamer][MSE] Fix stall in seek to end of buffered range 3cd4d31 [GStreamer][MSE] Fix stall in seek due to incomplete reenqueue b407c23 WKView: add a wpe_view_backend getter. c99d5ee [GStreamer] Notify player private (PlatformLayer) destruction to the d9f7dc6 Fix-for-delay-in-web-audio 06ff542 Generalise DB410c switch 427b052 [MSE] Don't try to adopt a floater. 259e898 Fix for 302 Redirect support (#356) 4e778b5 [WebInspector] Fix for elements page, use getPropertyValue instead of discontinued getPropertyCSSValue 313ff46 Add platform variable for DB410c f017f70 Using optimised vsink for platform DB410C 9a02007 [GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer 5674f3b [GStreamer][WebAudio] Avoid sending null data/silence 83a08d0 Add a page property for enabling console log with private browsing e2c897e Use -ffunction-sections/-fdata-sections/--gc-sections with clang too [where has this stuff gone?] cad2f3c Make Web Inspector Remote to listen on both IPv4 and IPv6 addresses 85504c3 Make the code inclusive of musl when OS is linux ae1b1e5 Use a setting to disable scrolling to the keyboard focused element instead of an env variable.
charlie-ht added a commit
that referenced
this pull request
Sep 13, 2017
Commits merged, [MSE] Fix BufUnbuf test from YouTube's MSE conformance test suite 06b35a8 [MSE] Improve SourceBuffer::appendBuffer() time e5b8d88 [MSE] Improve perfomance of SourceBuffer::evictCodedFrames ce724e5 [MSE] fix calculation of MediaSource::currentTimeFudgeFactor 26a5288 Cap the reported progress of implicit animations 7162d05 [MSE] Fix unsigned comparison warning. aec09ae [GStreamer][MSE] Make setAppendState thread safe 4508db9 [WPE] Enable MEMORY_SAMPLER 26614e8 Revert "[GStreamer][MSE] Add missing lock around getStreamByTrackId" aaab302 Use the return value of gst_mini_object_make_writable... b4df1c5 webbrige sets WPE_RAM_SIZE to 128M, which tickles a logic error in the cache model. 066c52b Fixed UI issues in webinspector b0e7fd8 Fix for issue #326 WebInspector-Popover 9cbbdd7 [WPEWebkit] Added support for ARMV8 processor. d3a3365 [GStreamer] Fix video resize problems after quality change b2ce7dc Fix for PageUp/PageDown keys 29c10d9 [Gstreamer] Make sure live stream is detected ef9a398 Fix for WebInspector-NetworkTab 71d0d30 [GStreamer] Fix for invalid video size information sometimes returned by getVideoSizeAndFormatFromCaps (gst_video_info_from_caps) 59fbb57 [GStreamer] Make volume control consistent 939aa76 [MSE][GStreamer] Fix premature video clip change on youtube 8dfa02e [GStreamer][MSE] Don't flush audio streams, only video streams 148ffdd Fixed bug with unneeded rangeRemoval 25c3dd3 [MSE][GStreamer] don't pause playback when there is enough data 9842bc6 [MSE][GStreamer] increase the playback buffer size 72a5ffc Fixed UI issues in webinspector 3f777e3 Fix for wpe PageClient overrides 5000203 Fixed MediaElementsEvents test 97c32be [MSE][GStreamer] Fix infinite loop in evictCodedFrames() when duration is infinite c11d0d4 Fixed typo indefiniteTime -> isIndefinite (#306) a4cc739 [MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evictable data in Source Buffer (#296) eec35dd minor compile errors [sic] d392c15 volume method wrapped with WPE, usage is not 4e9b1cf Add a METROLOGICAL define to be able to ifdef pieces of code specific to downstream WPE fdac418 Implemented custom headers per url 21f3896 Made fudge factor for audio a fraction c527870 Fix MSE video size test failures (#276) (#277) 277e5de [GStreamer][MSE] Reject too big channels/framerate/width/height mime type values Commits we might want but that conflict heavily or seem N/A. 254e68d Make scroll-to-focused-element behaviour configurable. d608ad3 Add <functional> header for std::functional 758f885 Fixed bug with wrong expires date in cookies 11727e2 [MSE][GStreamer] keep the ahead buffer when evicting coded frames 7fb21a9 [GStreamer][MSE] Fix stall in seek to end of buffered range 3cd4d31 [GStreamer][MSE] Fix stall in seek due to incomplete reenqueue b407c23 WKView: add a wpe_view_backend getter. c99d5ee [GStreamer] Notify player private (PlatformLayer) destruction to the d9f7dc6 Fix-for-delay-in-web-audio 06ff542 Generalise DB410c switch 427b052 [MSE] Don't try to adopt a floater. 259e898 Fix for 302 Redirect support (#356) 4e778b5 [WebInspector] Fix for elements page, use getPropertyValue instead of discontinued getPropertyCSSValue 313ff46 Add platform variable for DB410c f017f70 Using optimised vsink for platform DB410C 9a02007 [GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer 5674f3b [GStreamer][WebAudio] Avoid sending null data/silence 83a08d0 Add a page property for enabling console log with private browsing e2c897e Use -ffunction-sections/-fdata-sections/--gc-sections with clang too [where has this stuff gone?] cad2f3c Make Web Inspector Remote to listen on both IPv4 and IPv6 addresses 85504c3 Make the code inclusive of musl when OS is linux ae1b1e5 Use a setting to disable scrolling to the keyboard focused element instead of an env variable.
estobbart pushed a commit
to estobbart/WPEWebKit
that referenced
this pull request
Sep 14, 2017
* Fix for 302 Redirect support * Updated fix for 302 redirect support * Added check for invalid redirect url
charlie-ht added a commit
that referenced
this pull request
Sep 14, 2017
* Merge master into staging. Commits merged, [MSE] Fix BufUnbuf test from YouTube's MSE conformance test suite 06b35a8 [MSE] Improve SourceBuffer::appendBuffer() time e5b8d88 [MSE] Improve perfomance of SourceBuffer::evictCodedFrames ce724e5 [MSE] fix calculation of MediaSource::currentTimeFudgeFactor 26a5288 Cap the reported progress of implicit animations 7162d05 [MSE] Fix unsigned comparison warning. aec09ae [GStreamer][MSE] Make setAppendState thread safe 4508db9 [WPE] Enable MEMORY_SAMPLER 26614e8 Revert "[GStreamer][MSE] Add missing lock around getStreamByTrackId" aaab302 Use the return value of gst_mini_object_make_writable... b4df1c5 webbrige sets WPE_RAM_SIZE to 128M, which tickles a logic error in the cache model. 066c52b Fixed UI issues in webinspector b0e7fd8 Fix for issue #326 WebInspector-Popover 9cbbdd7 [WPEWebkit] Added support for ARMV8 processor. d3a3365 [GStreamer] Fix video resize problems after quality change b2ce7dc Fix for PageUp/PageDown keys 29c10d9 [Gstreamer] Make sure live stream is detected ef9a398 Fix for WebInspector-NetworkTab 71d0d30 [GStreamer] Fix for invalid video size information sometimes returned by getVideoSizeAndFormatFromCaps (gst_video_info_from_caps) 59fbb57 [GStreamer] Make volume control consistent 939aa76 [MSE][GStreamer] Fix premature video clip change on youtube 8dfa02e [GStreamer][MSE] Don't flush audio streams, only video streams 148ffdd Fixed bug with unneeded rangeRemoval 25c3dd3 [MSE][GStreamer] don't pause playback when there is enough data 9842bc6 [MSE][GStreamer] increase the playback buffer size 72a5ffc Fixed UI issues in webinspector 3f777e3 Fix for wpe PageClient overrides 5000203 Fixed MediaElementsEvents test 97c32be [MSE][GStreamer] Fix infinite loop in evictCodedFrames() when duration is infinite c11d0d4 Fixed typo indefiniteTime -> isIndefinite (#306) a4cc739 [MSE] [GStreamer] Fixing QUOTA_EXCEEDED_ERR fired when there was evictable data in Source Buffer (#296) eec35dd minor compile errors [sic] d392c15 volume method wrapped with WPE, usage is not 4e9b1cf Add a METROLOGICAL define to be able to ifdef pieces of code specific to downstream WPE fdac418 Implemented custom headers per url 21f3896 Made fudge factor for audio a fraction c527870 Fix MSE video size test failures (#276) (#277) 277e5de [GStreamer][MSE] Reject too big channels/framerate/width/height mime type values Commits we might want but that conflict heavily or seem N/A. 254e68d Make scroll-to-focused-element behaviour configurable. d608ad3 Add <functional> header for std::functional 758f885 Fixed bug with wrong expires date in cookies 11727e2 [MSE][GStreamer] keep the ahead buffer when evicting coded frames 7fb21a9 [GStreamer][MSE] Fix stall in seek to end of buffered range 3cd4d31 [GStreamer][MSE] Fix stall in seek due to incomplete reenqueue b407c23 WKView: add a wpe_view_backend getter. c99d5ee [GStreamer] Notify player private (PlatformLayer) destruction to the d9f7dc6 Fix-for-delay-in-web-audio 06ff542 Generalise DB410c switch 427b052 [MSE] Don't try to adopt a floater. 259e898 Fix for 302 Redirect support (#356) 4e778b5 [WebInspector] Fix for elements page, use getPropertyValue instead of discontinued getPropertyCSSValue 313ff46 Add platform variable for DB410c f017f70 Using optimised vsink for platform DB410C 9a02007 [GTK][WPE] border-radius with non visible border doesn't work on images that have their own RenderLayer 5674f3b [GStreamer][WebAudio] Avoid sending null data/silence 83a08d0 Add a page property for enabling console log with private browsing e2c897e Use -ffunction-sections/-fdata-sections/--gc-sections with clang too [where has this stuff gone?] cad2f3c Make Web Inspector Remote to listen on both IPv4 and IPv6 addresses 85504c3 Make the code inclusive of musl when OS is linux ae1b1e5 Use a setting to disable scrolling to the keyboard focused element instead of an env variable. * Fix style comments. These are from calvaris and the check-webkit-style, ignoring all warnings less than category level 5, because there's too many to fix (and calvaris didn't notice most of them :)) * Fix more style issues. The following is now silent, ./Tools/Scripts/check-webkit-style -g 90bc784..
estobbart pushed a commit
to estobbart/WPEWebKit
that referenced
this pull request
Sep 14, 2017
* Fix for 302 Redirect support * Updated fix for 302 redirect support * Added check for invalid redirect url
wouterlucas pushed a commit
that referenced
this pull request
Oct 4, 2017
* Fix for 302 Redirect support * Updated fix for 302 redirect support * Added check for invalid redirect url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for 302 Redirect support