Skip to content

Center the Steam sign-in error inside the password field - #702

Merged
maxjivi05 merged 2 commits into
mainfrom
fix/invalid-un-pw
Aug 27, 2026
Merged

Center the Steam sign-in error inside the password field#702
maxjivi05 merged 2 commits into
mainfrom
fix/invalid-un-pw

Conversation

@maxjivi05

Copy link
Copy Markdown
Contributor

The invalid-credentials message is an overlay on the password field rather than supportingText, so it takes no part in layout. Aligning it to BottomStart pinned its bottom edge to the field's bottom edge, and the 8dp downward offset then pushed it across the outline: the border stroke ran through the text and the first glyph collided with the rounded left corner.

Align to BottomCenter and raise it so it sits inside the field's lower inset, clear of the stroke. Horizontal padding keeps longer translations off the corners.

The invalid-credentials message is an overlay on the password field
rather than supportingText, so it takes no part in layout. Aligning it
to BottomStart pinned its bottom edge to the field's bottom edge, and
the 8dp downward offset then pushed it across the outline: the border
stroke ran through the text and the first glyph collided with the
rounded left corner.
Align to BottomCenter and raise it so it sits inside the field's lower
inset, clear of the stroke. Horizontal padding keeps longer
translations off the corners.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@maxjivi05
maxjivi05 merged commit 4f220c5 into mainAug 27, 2026
@maxjivi05
maxjivi05 deleted the fix/invalid-un-pw branch August 27, 2026 12:31
@maxjivi05Claude

Copy link
Copy Markdown
ContributorAuthor

Code looks solid. No critical issues found.

Reviewed against data integrity/cloud sync, concurrency, performance/memory, controller (PANE_NAV) accessibility, Android/Compose standards, and test coverage. This is a scoped, cosmetic layout fix confined to the AnimatedVisibility/Text alignment for the Steam login error message — no new UI components or menus are introduced (so the PANE_NAV rule doesn't apply here), no shared/mutable state or background work is touched, and the TextAlign import used is already present in the file. The repo has no existing screenshot/Compose UI test harness, so the absence of a regression test here is consistent with project-wide practice rather than a gap introduced by this change.


Generated by Claude Code

kingokksa added a commit to kingokksa/WinNative that referenced this pull request Aug 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maxjivi05