Skip to content

Fix the Java formatting violations spotless reports - #703

Merged
maxjivi05 merged 2 commits into
mainfrom
fix/spotless-java-formatting
Aug 27, 2026
Merged

Fix the Java formatting violations spotless reports#703
maxjivi05 merged 2 commits into
mainfrom
fix/spotless-java-formatting

Conversation

@maxjivi05

Copy link
Copy Markdown
Contributor

GcmRumbleMode.java was stored with CRLF line terminators; the other three had @nullable on its own line, which the configured formatAnnotations() step folds onto the declaration.

Whitespace only, no semantic change. Verified with javac.

GcmRumbleMode.java was stored with CRLF line terminators; the other
three had @nullable on its own line, which the configured
formatAnnotations() step folds onto the declaration.
Whitespace only, no semantic change. Verified with javac.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@maxjivi05
maxjivi05 merged commit 8018850 into mainAug 27, 2026
@maxjivi05
maxjivi05 deleted the fix/spotless-java-formatting branch August 27, 2026 12:33
@maxjivi05Claude

Copy link
Copy Markdown
ContributorAuthor

Code looks solid. No critical issues found.

This PR is whitespace-only: it folds @Nullable (and @Nullable @Override) onto the declaration line per the configured formatAnnotations() Spotless step, and normalizes GcmRumbleMode.java from CRLF to LF line endings. No logic, control flow, save/cloud-state, threading, or public API changes are present in the diff — reviewed against all 6 pillars (data integrity, concurrency, performance, controller accessibility, Android/C++ standards, test coverage), none of which apply here since no functional code changed.


Generated by Claude Code

kingokksa added a commit to kingokksa/WinNative that referenced this pull request Aug 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maxjivi05