Remove ignoreErrors from PHPStan

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.

[gziolo]

• Part of Scaffold repository tooling #13.

I audited ignoreErrors added to PHPStan (#6 (comment)). I decided to remove it and fix the PHPDoc to make PHPStan happy.

[justlevine]

@gziolo if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

(my 2c: We're not using nor relying on the real array shape, so this is just suppressing the external phpstan-wordpress error in the file by marking the generic they introduce as mixed so they don't get type-checked. tl;dr all this does is hide the error suppression inside the file implementation, instead of centrally declaring that we're not using the (3rd-party) generics for that file. ).

[gziolo]

if you don't mind the extra work stripping them out before merge into WP Core then go ahead and merge 🤷

I want to make sure all files are linted for now. I will figure out next week what to do if CI on wordpress-develop is largely unhappy. As an alternative, we might consider silencing only the errors related to generics.

[justlevine]

As an alternative, we might consider silencing only the errors related to generics.

FTR that was the pre-merge behavior... only generics from WP_REST_Request in those wp-rest/* files were being ignored.

• abilities-api/phpstan.neon.dist

  Lines 34 to 41 in 7736905

  	# WP_REST_Request is not actually a generic class in WordPress core.
  	# PHPStan's WordPress stubs appear to define it as generic for type checking,
  	# but WordPress itself doesn't use generics. This seems to be an incompatibility
  	# between static analysis tools and WordPress's actual implementation.
  	-
  	message: '#has parameter \$request with generic class WP_REST_Request but does not specify its types#'
  	paths:
  	- includes/rest-api/**/*.php

[gziolo]

True. I will revisit next week and revert if that makes more sense 👍🏻

[gziolo]

I tested in WordPress/wordpress-develop#9410 all the latest changes from trunk, and we can safely use more complex types in PHPDoc.