Add REST API controllers for Abilities API

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.

[emdashcodes]

Closes#2.

This PR adds initial REST API endpoints to the Abilities API with support for both resource (GET) and tool (POST) type abilities.

How

Implements the following REST API endpoints:

• WP_REST_Abilities_List_Controller - Handles listing abilities and retrieving individual abilities

  • GET /wp-json/wp/v2/abilities - List all registered abilities
  • GET /wp-json/wp/v2/abilities/{id} - Get a specific ability by ID

• WP_REST_Abilities_Run_Controller - Handles executing abilities

  • GET/POST /wp-json/wp/v2/abilities/{id}/run - Execute an ability (method depends on ability type)
    • Resources use GET
    • Tools use POST

Testing Steps

1. Make sure all unit tests pass

If you enable the Ability API as a plugin:

1. Test listing abilities: GET /wp/v2/abilities
2. Test getting a specific ability: GET /wp/v2/abilities/{id}
3. Test executing a resource ability: GET /wp/v2/abilities/{id}/run
4. Test executing a tool ability: POST /wp/v2/abilities/{id}/run

[gziolo]

I landed #3, which triggered GitHub automations, and accidentally closed this PR after the target branch got deleted 😅

I'll try to fix it.

[gziolo]

Reopened and changed the base branch, but it will require a rebase to remove my commits from the list of changes.

[gziolo]

I reviewed all the code and tests for the list controller and left my feedback inline. I still need to check the run controller. Everything is looking great, my feedback is mostly about minor things or I had some questions/notes where I wasn't entirely sure how it works.

My only high-level, important feedback is around using a single form: id or name to uniquely identify the ability.

[Copilot]

Pull Request Overview

This PR implements REST API controllers for the Abilities API, enabling web-based access to both resource and tool type abilities through standardized endpoints.

Key Changes:

• Added two REST API controllers (WP_REST_Abilities_List_Controller and WP_REST_Abilities_Run_Controller) with full test coverage
• Implemented HTTP method validation where resource abilities use GET and tool abilities use POST
• Added comprehensive validation for input/output schemas and permission checks

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/rest/class-wp-rest-abilities-list-controller.php	Implements endpoints for listing and retrieving individual abilities
src/rest/class-wp-rest-abilities-run-controller.php	Handles ability execution with method validation and comprehensive error handling
src/rest/class-wp-rest-abilities-init.php	Initializes and registers REST API routes on the rest_api_init hook
tests/unit/REST/WPRESTAbilitiesListControllerTest.php	Comprehensive test coverage for list controller including pagination and permissions
tests/unit/REST/WPRESTAbilitiesRunControllerTest.php	Extensive test coverage for run controller including method validation and error handling
Various test and configuration files	Supporting infrastructure for unit testing and development

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

❌ Patch coverage is 91.10429% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (trunk@c40f122). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...rc/rest/class-wp-rest-abilities-run-controller.php	81.57%	28 Missing ⚠️
abilities-api.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## trunk #6 +/- ##
========================================
Coverage ? 90.32% Complexity ? 103 ========================================
Files ? 7 Lines ? 558 Branches ? 0 ========================================
Hits ? 504 Misses ? 54 Partials ? 0 

Flag	Coverage Δ
unit	90.32% <91.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emdashcodes]

I've addressed the static analysis and PHPCS issues from this branch. The remaining ones seem to be on trunk.

[justlevine]

Is there a reason not to use WP_REST_Request->get_param() (/ ->get_params() elsewhere )?

We lose the rest_request_parameter_order filter by relying on \ArrayAccess

[gziolo]

I see both forms used in REST API controllers included in WP core, sometimes even in the same handler 😅

[justlevine]

@gziolo I think that's a sign of tech debt, not an endorsement of pattern 😅

[gziolo]

We can update to use get_param() 👍🏻

Will you take care of it?

[gziolo]

Thank you for rebasing with trunk and addressing all feedback. I see the increased unit tests coverage added in 9b071cb 👏🏻

Let's land it in the current shape and address the code quality configuration challenges seperately. I also plan to open follow-up issues for TODO items included in the codebase.