Uh oh!
There was an error while loading. Please reload this page.
HTML API: Add support for BUTTON element - #4955
Closed
dmsnell wants to merge 2 commits into
Closed
Conversation
dmsnellforce-pushed
the
html-api/support-button-element
branch
2 times, most recently
from
August 2, 2023 18:23
c780384 to
47711b7Compare10 tasks
ockham
reviewed
Aug 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
ockham
reviewed
Aug 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
ockham
reviewed
Aug 7, 2023
ockham
left a comment
Contributor
There was a problem hiding this comment.
Two small notes, but looking good overall!
dmsnellforce-pushed
the
html-api/support-button-element
branch
from
August 8, 2023 05:15
47711b7 to
b245533CompareIn this patch we're adding support to process the BUTTON element. This requires adding some additional semantic rules to handle situations where a BUTTON element is already in scope.
dmsnellforce-pushed
the
html-api/support-button-element
branch
from
August 9, 2023 18:27
5ad4fd6 to
604c1d9Compareockham
commented
Aug 10, 2023
Contributor
Committed to Core in https://core.trac.wordpress.org/changeset/56380/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #58961
In this patch we're adding support to process the BUTTON element. This requires adding some additional semantic rules to handle situations where a BUTTON element is already in scope.
Also included is a fixup to enforce that
WP_HTML_Processor::next_tag()never returns for a tag closer. This is useful with the Tag Processor, but not for the HTML Processor. There were tests relying on this behavior to assert that internal processes were working as they should, but those tests have been updated to use the semi-privatestep()function, which does stop on tag closers.This patch is one in a series of changes to expand support within the HTML API, moving gradually to allow for more focused changes that are easier to review and test. The HTML Processor is a work in progress with a certain set of features slated to be ready and tested by 6.4.0, but it will only contain partial support of the HTML5 specification even after that. Whenever it cannot positively recognize and process its input it bails, and certain function stubs and logical stubs exist to structure future expansions of support.