Uh oh!
There was an error while loading. Please reload this page.
HTML API: add get/set inner/outer markup - #4956
Draft
dmsnell wants to merge 5 commits into
Draft
Conversation
dmsnellforce-pushed
the
html-api/add-get-set-inner-outer-contents
branch
2 times, most recently
from
August 3, 2023 00:42
e2a7146 to
851b3c7Comparedmsnellforce-pushed
the
html-api/add-get-set-inner-outer-contents
branch
5 times, most recently
from
August 3, 2023 22:06
060d219 to
de410cdComparedmsnellforce-pushed
the
html-api/add-get-set-inner-outer-contents
branch
2 times, most recently
from
August 9, 2023 18:23
242e8ba to
18cc399Comparedmsnell
commented
Aug 9, 2023
MemberAuthor
dmsnellforce-pushed
the
html-api/add-get-set-inner-outer-contents
branch
3 times, most recently
from
August 14, 2023 14:51
6698cd9 to
43db05fComparedmsnellforce-pushed
the
html-api/add-get-set-inner-outer-contents
branch
from
November 16, 2023 20:40
43db05f to
79bf013Compare10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Do not merge: This incorporates two other PRs, which may change before they are merged.
Todo
substr_bookmarksandreplace_with_bookmarksQuestions
rawto the names to indicate even more that these are making potentially-destructive operations? This doesn't escape HTML because it can't, if it's already provided an HTML string. This also doesn't validate semantic rules, for example, adding a paragraph inside a paragraph. e.g.set_raw_inner_markup()Description
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.