Uh oh!
There was an error while loading. Please reload this page.
Harden Pulse lifecycle for v0.1.0 - #1
Merged
Conversation
zekageri
marked this pull request as ready for review
July 14, 2026 18:44
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Pulse v0.1.0 release-blocker remediation plan on
pulse-production-hardening.Lifecycle and shutdown
Uninitialized,Running,Stopping, andStoppedlifecycle statesend()waiters cannot stop a newer runPulseImplduringinit()init()has published its handle, generation, andRunningstateTimeoutStoppedas scheduler quiescence before physical task deletionPulseis destroyed from its own callbackBusywhen publicend()is called from the Pulse taskQueue and timer controls
Diagnostics and allocation behavior
std::function, callback-capture, andshared_ptrallocation behaviorRuntime tests and release gates
Pulse.cpplibrary.propertiesandlibrary.jsonto0.1.0extras/PulseSmokeCHANGELOG.mdrelease notes and updated lifecycle/API documentationValidation
GitHub Actions run
29341692432passed the main CI workflow on the previous head. A follow-up commit moved the smoke sketch underextras/PulseSmoketo satisfy Arduino Lint ruleLD003.-fno-exceptionsproduction compilation: passedRemaining manual release gate
Keep this PR as draft until
extras/PulseSmokehas been executed on physical hardware with:The sketch is compiled in CI for the full board matrix, but this PR does not claim that physical hardware execution was performed.
Scope note
The existing
shared_ptrtimer-record ownership remains in place for v0.1.0. Avoidable callback copies were removed and the allocation contract is documented accurately. Replacing theshared_ptrcontrol-block allocation remains optional follow-up hardening and should not delay the lifecycle safety fixes.