Uh oh!
There was an error while loading. Please reload this page.
fix: resolve Pulse v0.1.0 release blockers - #2
Closed
zekageri wants to merge 5 commits into
Closed
Conversation
zekageri
commented
Jul 14, 2026
CollaboratorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end()handling, task-owned cleanup, intrusive implementation lifetime, and join-style destruction0.1.0package metadata and curated changelog-based release notesWhy
The previous implementation could free
PulseImplwhile its task was still active, race queue deletion against public operations, report incorrect stack diagnostics, and accept callback controls that could later disappear or be overwritten. Compilation-only CI could not detect those behaviors.Behavioral impact
end()called from a Pulse callback returnsBusyend()timeout leaves Pulse safely inStopping; a later call may continue waitingBusyduring shutdownValidation
Local validation completed before publishing:
end(), external destruction, self-destruction, and full-queue shutdown tests passed-fno-exceptions -Wall -Wextra -Werrorproduction-source compilation passedCI / hardware
The existing PIOArduino and Arduino CLI board matrices remain required. CI also compiles the new device smoke sketch. Physical internal-stack and PSRAM-stack smoke runs remain part of the final release checklist when no hardware runner is connected.