Uh oh!
There was an error while loading. Please reload this page.
Feature/no connection serial - #983
Merged
Merged
Conversation
…n-serial-recovery-key
…ry-key Feature/no connection serial recovery key
…y/ably-java into feature/no-connection-serial
sacOO7force-pushed
the
feature/no-connection-serial
branch
from
February 6, 2024 20:45
b6210aa to
c0fd61fCompareSimonWoolf
approved these changes
Feb 9, 2024
SimonWoolf
left a comment
Member
There was a problem hiding this comment.
Giving this a fairly cursory lookthrough since all the individual parts should already have been reviewed (and with the caveat that I'm not very familiar with the ably-java codebase), but can't see anything obviously wrong 👍
sacOO7
commented
Feb 12, 2024
ContributorAuthor
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed#974
Fixed#846
Fixed#976