Uh oh!
There was an error while loading. Please reload this page.
[ECO-4058][Protocol-2] Fix protocol 2 tests - #411
Closed
sacOO7 wants to merge 65 commits into
Closed
Conversation
incoming_message_dispatcher
…eceived on ack/nack
1. nil or empty string 2. fetch with default value for hash
sacOO7force-pushed
the
feature/protocol-2-tests
branch
from
June 10, 2024 06:17
f470f3d to
29635edComparechecks for the same are dependent on connection serial.
…d as a part of separate PR
This was referenced Jun 24, 2024
# Conflicts: # lib/ably/realtime/client/incoming_message_dispatcher.rb # lib/ably/realtime/presence/presence_manager.rb
Replace error message checks with error code checks. Error messages are not guaranteed to be consistent across versions/systems but the error codes are.
rest/channel_spec: fix test checking error messages
…-tests # Conflicts: # lib/ably/realtime/channel.rb # lib/ably/realtime/channel/channel_manager.rb # lib/ably/realtime/channel/channel_state_machine.rb # lib/ably/realtime/connection.rb
This reverts commit 863503c.
sacOO7
commented
Jul 5, 2024
ContributorAuthor
Closing in favor of #426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making sure connection state is connected before attaching channelbecause if reduces flakiness of the tests