Skip to content

Base codec functionality - #1

Closed
codemerx wants to merge 1 commit into
masterfrom
feature-base-functionality
Closed

Base codec functionality#1
codemerx wants to merge 1 commit into
masterfrom
feature-base-functionality

Conversation

@codemerx

@codemerxcodemerx commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

This is the delta-codec-java as described at https://github.com/ably/wiki/issues/380#issuecomment-533647591

@QuintinWillison

Copy link
Copy Markdown
Contributor

Given the lack of activity on this PR and the underlying branch, @codemerx , could you please consider merging it to master and then rebase #3 to target master (once you've confirmed we can get rid of #2)?

@codemerx

Copy link
Copy Markdown
ContributorAuthor

Given the lack of activity on this PR and the underlying branch, @codemerx , could you please consider merging it to master and then rebase #3 to target master (once you've confirmed we can get rid of #2)?

Argh I forgot to add @paddybyers as a reviewer when I created this. I'd gladly merge it but @QuintinWillison and @paddybyers could you review it beforehand?

@QuintinWillisonQuintinWillison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as to the purpose of this repository.

All I was expecting to see exported, for consumption by our client library, was a single stateless function (i.e. static method) taking two byte arrays and returning one byte array.

The thing is, that's surely what com.davidehrmann.vcdiff.VCDiffDecoder does already?

So, is this repository just for those not using ably-java (i.e. SSE / MQTT)?

@paddybyers

Copy link
Copy Markdown
Member

Closing this PR - incorporated into #3

@QuintinWillison
QuintinWillison deleted the feature-base-functionality branch June 16, 2020 13:25
@codemerxcodemerx removed their assignment Oct 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codemerx@QuintinWillison@paddybyers@tsviatko