Skip to content

Adding stateless delta decoding API - #2

Closed
codemerx wants to merge 1 commit into
feature-base-functionalityfrom
feature-stateless-api
Closed

Adding stateless delta decoding API #2
codemerx wants to merge 1 commit into
feature-base-functionalityfrom
feature-stateless-api

Conversation

@codemerx

@codemerxcodemerx commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Adds the stateless delta decoding API:

 static isDelta(payload: Buffer): bool
static applyDelta(current: Buffer, previous: Buffer): Buffer

@paddybyerspaddybyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments apply to both PRs that are here.

Please can we have a README that includes a description of the purpose of this library and an overview of the API and how it is used. I know that primarily we will be pointing developers at the Ably codec, but this library still needs to be usable in its own right.

Also, what are your plans for CI?

I think if possible we should construct a test and example app that doesn't use Ably. Do you have any thoughts about that?

@QuintinWillison

Copy link
Copy Markdown
Contributor

@codemerx, is this branch now obsolete, replaced by that underlying #3?

If so could you please close this PR and delete the branch, albeit after ensuring you've done something to address @paddybyers's comment, even if that just means raising issues for the backlog.

Thanks.

@codemerx

Copy link
Copy Markdown
ContributorAuthor

@codemerx, is this branch now obsolete, replaced by that underlying #3?

If so could you please close this PR and delete the branch, albeit after ensuring you've done something to address @paddybyers's comment, even if that just means raising issues for the backlog.

Thanks.

Yep this should be obsolete and it makes to sense to address teh comment. I am a bit hesitant to delete the branch, however, before the new structure gets final approval.

@QuintinWillison
QuintinWillison deleted the feature-stateless-api branch June 16, 2020 13:25
@codemerxcodemerx removed their assignment Oct 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codemerx@QuintinWillison@paddybyers@tsviatko