Skip to content
This repository was archived by the owner on Aug 10, 2026. It is now read-only.

Message Interactions - #1444

Merged
Peter-Maguire merged 19 commits into
mainfrom
message_interactions
Jul 1, 2022
Merged

Message Interactions#1444
Peter-Maguire merged 19 commits into
mainfrom
message_interactions

Conversation

@Peter-Maguire

@Peter-MaguirePeter-Maguire commented May 30, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

NOTE TO REVIEWERS - please do not review PRs in the DRAFT state, as the PR may change substantially before it is ready to review. Thanks.

Description

Adds message interaction object into message extras, and a method for subscribing to channel messages with a filter.

Review

The context behind this PR can be obtained from this document

@Peter-MaguirePeter-Maguire self-assigned this May 30, 2022
@Peter-MaguirePeter-Maguire changed the title Initial commit with subscription filteringMessage InteractionsMay 30, 2022
cruickshankpg
cruickshankpg reviewed May 30, 2022
View reviewed changes

@cruickshankpgcruickshankpg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
@Peter-Maguire
Peter-Maguire marked this pull request as ready for review May 31, 2022 13:23
@ablyably deleted a comment from lmarsJun 6, 2022
owenpearson
owenpearson suggested changes Jun 7, 2022
View reviewed changes
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Peter Maguireand others added 3 commits June 8, 2022 10:33
@Peter-Maguire
Peter-Maguire requested review from owenpearson and removed request for lmarsJune 14, 2022 12:19
owenpearson
owenpearson suggested changes Jun 14, 2022
View reviewed changes
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
@Peter-MaguirePeter-Maguire mentioned this pull request Jun 17, 2022
Merged
lmars
lmars reviewed Jun 24, 2022
View reviewed changes
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
lmars
lmars reviewed Jun 24, 2022
View reviewed changes
Comment threadcontent/client-lib-development-guide/features.textile Outdated
@Peter-Maguire
Peter-Maguire requested a review from lmarsJune 27, 2022 12:23
owenpearson
owenpearson suggested changes Jun 27, 2022
View reviewed changes
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Peter Maguire@owenpearson
Update content/client-lib-development-guide/features.textile
da6abf8
Co-authored-by: Owen Pearson <48608556+owenpearson@users.noreply.github.com>
owenpearson
owenpearson suggested changes Jun 29, 2022
View reviewed changes
Comment threadcontent/client-lib-development-guide/features.textile Outdated
Peter Maguire@owenpearson
Remove contradictory MessageFilter reference
07bee58
Co-authored-by: Owen Pearson <48608556+owenpearson@users.noreply.github.com>
owenpearson
owenpearson approved these changes Jun 29, 2022
View reviewed changes

@owenpearsonowenpearson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

lmars
lmars reviewed Jul 1, 2022
View reviewed changes

@lmarslmars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline with the effort being done in https://github.com/ably/docs/pull/1477/files, I think ReferenceExtras and MessageFilters need a spec point which documents the fields, and then a reference to those spec points in the IDL

Comment threadcontent/client-lib-development-guide/features.textile Outdated
@Peter-Maguire
Peter-Maguire requested a review from lmarsJuly 1, 2022 11:59
lmars
lmars approved these changes Jul 1, 2022
View reviewed changes

@lmarslmars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Peter-Maguire
Peter-Maguire merged commit 7cf01a2 into mainJul 1, 2022
@Peter-Maguire
Peter-Maguire deleted the message_interactions branch July 1, 2022 14:51
@SapplesSapples mentioned this pull request Jul 27, 2022
Merged
7 tasks
@QuintinWillisonQuintinWillison mentioned this pull request Sep 28, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paddybyerspaddybyersAwaiting requested review from paddybyers
@JmgrJmgrAwaiting requested review from Jmgr
@mattheworiordanmattheworiordanAwaiting requested review from mattheworiordan
3 more reviewers
@lmarslmarslmars approved these changes
@cruickshankpgcruickshankpgcruickshankpg approved these changes
@owenpearsonowenpearsonowenpearson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Peter-MaguirePeter-Maguire

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Peter-Maguire@lmars@Jmgr@cruickshankpg@owenpearson@tbedford