Uh oh!
There was an error while loading. Please reload this page.
rebase and update IDL changes - #18
Conversation
m-hulbert
left a comment
There was a problem hiding this comment.
Quite a few comments on this one, sorry. Happy to walk through it with you though if that would help.
In addition there's some things that were missing from the linked PRs, as well as one change I think is in a separate PR that wasn't listed in the original JIRA but should be covered as part of this:
- Update
RestandRealtimetoRestClientandRealtimeClientand all associated links as per https://github.com/ably/docs/pull/1459/files. Be aware of any mention of "REST client" or "Realtime client" as well as any links to those classes. Authshould have atokenDetailsproperty as per https://github.com/ably/docs/pull/1462/files- I think the description for
extrasin theMessageclass needs to be updated due to the message interactions implementation. - ably/docs#1499 added
clientIdto message filters. This needs to be added. - The
cipherproperty needs updating inChannelOptionsas per ably/docs#1464 - I made a comment about making deprecated properties consistent in a few places, so happy to help with this too!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
m-hulbert
left a comment
There was a problem hiding this comment.
- All the references to
Stats.*objects should be in backticks. - I think the stats descriptions need checking over again. I think the descriptions have been carried through for them all about the "count and byte value of messages", however this can be quite nested. Taking
Stats.MessageDirectionsas an example, two of the properties areStats.MessageTrafficand the other isStats.MessageTypesyet they all have the same description. This applies to all the stats classes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
m-hulbert
left a comment
There was a problem hiding this comment.
The cipher property needs updating in ChannelOptions as per ably/docs#1464 still please.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
m-hulbert
left a comment
There was a problem hiding this comment.
Just a couple of styling points and a few stats suggestions!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Based on: EDX-180
Follow up/replacement from old PR to be closed: #5