Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 10, 2026. It is now read-only.
Rename client classes - #1459
Merged
Merged
Conversation
For consistency throughout the spec.
lawrence-forooghian
marked this pull request as ready for review
June 15, 2022 12:36
lawrence-forooghian
requested review from
QuintinWillison, SimonWoolf, lmars, m-hulbert, owenpearson, paddybyers and tbedford
and removed request for
paddybyersJune 15, 2022 12:36
lawrence-forooghian added a commit
that referenced
this pull request
Jun 15, 2022
lawrence-forooghian
requested review from
Morganamilo, Peter-Maguire, Rosalita, ikbalkaya, maratal, mohyour, stmoreau and tomkirbygreen
and removed request for
SimonWoolf, lmars, m-hulbert, paddybyers and tbedfordJune 15, 2022 17:19
ikbalkaya
approved these changes
Jun 16, 2022
Peter-Maguire
approved these changes
Jun 16, 2022
QuintinWillison
approved these changes
Jun 17, 2022
QuintinWillison
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement. Well spotted. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the
RestandRealtimeclasses toRestClientandRealtimeClientfor consistency throughout the spec (where this terminology was already being used in some places) and to match the IDL.