Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 10, 2026. It is now read-only.
Give REST and Realtime channel and presence classes unique names - #1460
Merged
tbedford merged 2 commits intoJun 20, 2022
Merged
Conversation
lawrence-forooghian
marked this pull request as ready for review
June 15, 2022 12:41
lawrence-forooghian
requested review from
QuintinWillison, SimonWoolf, lmars, m-hulbert, owenpearson, paddybyers and tbedfordJune 15, 2022 12:41
lawrence-forooghian added a commit
that referenced
this pull request
Jun 15, 2022
lawrence-forooghian
requested review from
Morganamilo, Peter-Maguire, Rosalita, ikbalkaya, maratal, mohyour, stmoreau and tomkirbygreen
and removed request for
SimonWoolf, lmars, m-hulbert, paddybyers and tbedfordJune 15, 2022 17:18
Peter-Maguire
approved these changes
Jun 16, 2022
maratal
approved these changes
Jun 16, 2022
QuintinWillison
approved these changes
Jun 17, 2022
ikbalkaya
approved these changes
Jun 17, 2022
owenpearson
approved these changes
Jun 17, 2022
The REST Channel and realtime Channel are two different classes (as is clear from the IDL, where they already have the names RestChannel and RealtimeChannel), so they should have different naming in the spec too. Some of the spec – e.g. RSH7 – was also already using this naming.
Motivation as in 407e709.
lawrence-forooghianforce-pushed
the
give-rest-and-realtime-channel-and-presence-classes-unique-names
branch
from
June 19, 2022 18:38
145ee58 to
5794085Comparetbedford
deleted the
give-rest-and-realtime-channel-and-presence-classes-unique-names
branch
June 20, 2022 07:13
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The REST
Channeland RealtimeChannelare two different classes (as is clear from the IDL, where they already have the namesRestChannelandRealtimeChannel), so they should have different naming in the spec too. Ditto forPresence.Some of the spec – e.g. RSH7 – was also already using this naming.