Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 10, 2026. It is now read-only.
[EDX-156] Add realtimeRequestTimeout to ClientOptions - #1465
Merged
tbedford merged 1 commit intoJun 20, 2022
Conversation
This already exists as a user-configurable ClientOptions property in several of our SDKs: - ably-java@7fc1939 - ably-js@48a66d6 (been configurable there since 1b355bf in 2015) - ably-ruby@f5eac15 - ably-go@32ed667 - ably-flutter@2fe0059 Furthermore, it seems consistent to allow this timeout to be configured, the same way as the others can be.
lawrence-forooghian
marked this pull request as ready for review
June 15, 2022 18:57
realtimeRequestTimeout to ClientOptionslawrence-forooghian
requested review from
Morganamilo, Peter-Maguire, QuintinWillison, Rosalita, ikbalkaya, maratal, mohyour, owenpearson, stmoreau and tomkirbygreenJune 15, 2022 18:57
lawrence-forooghian added a commit
to ably/ably-js
that referenced
this pull request
Jun 15, 2022
Peter-Maguire
approved these changes
Jun 16, 2022
maratal
approved these changes
Jun 16, 2022
QuintinWillison
approved these changes
Jun 17, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This already exists as a user-configurable
ClientOptionsproperty in several of our SDKs:7fc193948a66d6(been configurable there since1b355bfin 2015)f5eac1532ed6672fe0059Furthermore, it seems consistent to allow this timeout to be configured, the same way as the others can be.