Uh oh!
There was an error while loading. Please reload this page.
[PUB-925] Add new protocol message flags, actions, channel modes and message types for Objects - #279
Merged
Conversation
VeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 13, 2025 10:09
a74f41f to
cac4111CompareVeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 13, 2025 10:11
cac4111 to
380eb38CompareVeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 13, 2025 10:33
380eb38 to
490b953CompareVeskeRforce-pushed
the
add-activate-action
branch
from
March 13, 2025 10:37
c5de3cc to
d44ca77CompareVeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 13, 2025 10:39
490b953 to
92b5a16CompareVeskeR
commented
Mar 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
VeskeR
commented
Mar 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
VeskeR
commented
Mar 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
SimonWoolf
approved these changes
Mar 14, 2025
SimonWoolf
left a comment
Member
There was a problem hiding this comment.
I'm not super familiar with the state protocol, so just reviewing from the POV of well-formed-ness as a spec. From that POV this looks fine, nice job 👍. couple minor nitpicks.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mschristensen
requested changes
Mar 17, 2025
mschristensen
left a comment
Contributor
There was a problem hiding this comment.
Suggested a couple of small changes & also echo Simon's comments, after that looks good
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
VeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 19, 2025 08:18
92b5a16 to
f79593cCompareVeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 19, 2025 08:45
f79593c to
74e2319CompareVeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
March 19, 2025 08:53
74e2319 to
7669d86CompareVeskeR added a commit
to ably/ably-js
that referenced
this pull request
Mar 27, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
lawrence-forooghian
approved these changes
Mar 27, 2025
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Mar 31, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 1, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 1, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
… and ChannelMetrics for Objects Resolves PUB-925
VeskeRforce-pushed
the
PUB-925/objects-channel-changes
branch
from
April 1, 2025 09:38
3ec3f47 to
139c972CompareVeskeR
commented
Apr 1, 2025
ContributorAuthor
Renamed |
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR added a commit
to ably/ably-js
that referenced
this pull request
May 8, 2025
See Simon's comment [1]. The `channel` property should not be expected in the wire protocol for object messages, just like it isn't present in a message or presencemessage. [1] ably/specification#279 (comment)
ttypic pushed a commit
that referenced
this pull request
Mar 6, 2026
"binary" is used more frequently in the spec and is a bit more generic than "buffer". For more context see the discussion in the PR [1]. [1] #279 (comment)
ttypic pushed a commit
that referenced
this pull request
Mar 6, 2026
"binary" is used more frequently in the spec and is a bit more generic than "buffer". For more context see the discussion in the PR [1]. [1] #279 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves PUB-925