Skip to content

Add Objects flags, channel modes and message types - #298

Merged
VeskeR merged 7 commits into
mainfrom
objects-message
Apr 17, 2025
Merged

Add Objects flags, channel modes and message types#298
VeskeR merged 7 commits into
mainfrom
objects-message

Conversation

@VeskeR

@VeskeRVeskeR commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

This is the https://github.com/ably/specification/tree/integration/objects branch rebased onto the current main. Decided to rebase instead of merging main into the integration/objects to avoid a merge commit and preserve a cleaner history. Justified in this case as we only ever merged #279 PR into the integration/objects branch, so we're not losing much PR history by rebasing.

How to review:
ac11798 and 72cc202 commits were reviewed as part of the #279 PR (ref lost due to rebase) and there is no need to re-review. These added protocol message flags, channel modes and message types for Objects.

This PR also adds 4 small commits to fix some minor issues and reserve spec points for the Objects spec itself. Please review next commits (couple of lines each):
121a226
2730578
ebc51b6
23903db

This PR also bumps the specification version to 3.1.0 in 19f3fcd

@VeskeR
VeskeR marked this pull request as ready for review April 17, 2025 08:52
@VeskeRVeskeR mentioned this pull request Apr 17, 2025
… and ChannelMetrics for Objects
Resolves PUB-925
This is a rebased commit. Original commit 63631f0 for the
Objects channel modes and types PR [1]
[1] #279
This is a rebased commit. Original commit 139c972 for the
Objects channel modes and types PR [1]
[1] #279
Comment threadtextile/features.textile
Comment threadtextile/features.textile
Comment threadtextile/features.textile
Comment threadtextile/features.textile
Comment threadtextile/features.textile
Comment threadtextile/features.textile
Comment threadtextile/features.textile
Comment threadtextile/features.textile
VeskeR added a commit that referenced this pull request May 29, 2025
It should never have been named `map`, it was a type in #298
@VeskeRVeskeR mentioned this pull request May 29, 2025
Comment threadtextile/features.textile
lawrence-forooghian pushed a commit that referenced this pull request Jun 5, 2025
It should never have been named `map`, it was a type in #298
Comment threadtextile/features.textile
VeskeR added a commit that referenced this pull request Jun 5, 2025
It should never have been named `map`, it was a type in #298
Comment threadtextile/features.textile
@VeskeRVeskeR added the live-objects Related to LiveObjects functionality. label Jun 13, 2025
VeskeR added a commit to ably/ably-js that referenced this pull request Jun 20, 2025
…Message class
Based on the spec added in [1], and updates to the spec made in [2] and [3]
[1] ably/specification#298
[2] ably/specification#327
[3] ably/specification#328
VeskeR added a commit to ably/ably-js that referenced this pull request Jun 26, 2025
…Message class
Based on the spec added in [1], and updates to the spec made in [2] and [3]
[1] ably/specification#298
[2] ably/specification#327
[3] ably/specification#328
ttypic pushed a commit that referenced this pull request Mar 6, 2026
Add Objects flags, channel modes and message types
ttypic pushed a commit that referenced this pull request Mar 6, 2026
It should never have been named `map`, it was a type in #298
ttypic pushed a commit that referenced this pull request Mar 6, 2026
Add Objects flags, channel modes and message types
ttypic pushed a commit that referenced this pull request Mar 6, 2026
It should never have been named `map`, it was a type in #298
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live-objectsRelated to LiveObjects functionality.

Development

Successfully merging this pull request may close these issues.

4 participants

@VeskeR@mschristensen@sacOO7@lawrence-forooghian