Skip to content

Updated documentation/workflows to use actions/setup-node@v3 - #433

Merged
brcrista merged 3 commits into
actions:mainfrom
magnetikonline:update-readme-workflow-v3
Mar 31, 2022
Merged

Updated documentation/workflows to use actions/setup-node@v3#433
brcrista merged 3 commits into
actions:mainfrom
magnetikonline:update-readme-workflow-v3

Conversation

@magnetikonline

@magnetikonlinemagnetikonline commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Description:

  • Congrats on the @v3 release - noted that some documentation hasn't been updated to suit.
  • Left the ADRs as is - figured they should be "frozen in time" of authoring.
  • Also updated internal GitHub workflows that use itself to @v3.
  • Also fixed the README.md build badges to the new format generated by the GitHub Actions UI (Create status badge).

Related issue:
N/A

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@magnetikonlinemagnetikonline changed the title Update readme workflow v3Updated documentation/workflows to use actions/setup-node@v3Mar 2, 2022
@magnetikonlinemagnetikonline mentioned this pull request Mar 3, 2022
2 tasks
@magnetikonline

Copy link
Copy Markdown
ContributorAuthor

ping @brcrista

@vsafonkinvsafonkin mentioned this pull request Mar 31, 2022
2 tasks

@brcristabrcrista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @magnetikonline !

Comment threadREADME.md
Comment on lines +3 to +5
[![build-test](https://github.com/actions/setup-node/actions/workflows/build-test.yml/badge.svg)](https://github.com/actions/setup-node/actions/workflows/build-test.yml)
[![versions](https://github.com/actions/setup-node/actions/workflows/versions.yml/badge.svg)](https://github.com/actions/setup-node/actions/workflows/versions.yml)
[![proxy](https://github.com/actions/setup-node/actions/workflows/proxy.yml/badge.svg)](https://github.com/actions/setup-node/actions/workflows/proxy.yml)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brcrista
brcrista merged commit 546fd45 into actions:mainMar 31, 2022
@magnetikonline

Copy link
Copy Markdown
ContributorAuthor

Thx @brcrista 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetikonline@vsafonkin@dmitry-shibanov@brcrista