Skip to content

Bump to actions/checkout@v3 - #437

Merged
dmitry-shibanov merged 2 commits into
actions:mainfrom
magnetikonline:bump-checkout-action
Apr 1, 2022
Merged

Bump to actions/checkout@v3#437
dmitry-shibanov merged 2 commits into
actions:mainfrom
magnetikonline:bump-checkout-action

Conversation

@magnetikonline

@magnetikonlinemagnetikonline commented Mar 8, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

  • Bump actions/checkout to @v3
  • Also noted (and bumped) actions/upload-artifact to @v3 (released after I cut this PR).

https://github.com/actions/checkout/releases/tag/v3.0.0

Related issue:
N/A

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@magnetikonline

magnetikonline commented Mar 31, 2022

Copy link
Copy Markdown
ContributorAuthor

ping @brcrista

@vsafonkin

vsafonkin commented Mar 31, 2022

Copy link
Copy Markdown

Hi @magnetikonline, perhaps, it would be better to include these changes to #433 , what do you think?

@magnetikonline

magnetikonline commented Mar 31, 2022

Copy link
Copy Markdown
ContributorAuthor

Hi @magnetikonline, perhaps, it would be better to include these changes to #433 , what do you think?

thanks @vsafonkin - typically I like to keep these PRs as small a changeset as possible so they are easier to reason with - hence the dual PRs - but if it's easier - can certainly combine them.

@brcrista

brcrista commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

I went ahead and merged #433, so we can just move forward with this one separately. Looks like there are some merge conflicts now.

@magnetikonline
magnetikonline requested a review from a teamApril 1, 2022 02:53
@magnetikonline

magnetikonline commented Apr 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Done @brcrista - just re-created from main and added a bump for actions/upload-artifact too.

@magnetikonline

magnetikonline commented Apr 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Hrm - noted one of the Yarn 2 e2e tests is now failing. Can't see how these changes introduce this issue?

Screen Shot 2022-04-01 at 2 01 59 pm

@dmitry-shibanov

dmitry-shibanov commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

Hello @magnetikonline. Thank you for your pull request. I think it was a random issue. I've resolved it by rerunning. Is pull request ready?

@magnetikonline

magnetikonline commented Apr 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Wonderful @dmitry-shibanov - yeah all tests now passing 👍

Ready for approval/merge.

@dmitry-shibanov
dmitry-shibanov merged commit 7571663 into actions:mainApr 1, 2022
@magnetikonlinemagnetikonline mentioned this pull request Apr 1, 2022
Merged
2 tasks
@magnetikonline
magnetikonline deleted the bump-checkout-action branch April 1, 2022 08:26
@dmitry-shibanovdmitry-shibanov mentioned this pull request Apr 5, 2022
Closed
2 tasks
ghost
ghost reviewed May 7, 2022
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsafonkin

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
@dependabot
chore(deps-dev): bump typescript from 4.8.3 to 4.8.4 (actions#437)
f309cf5
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.3 to 4.8.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.8.3...v4.8.4)
---
updated-dependencies:
- dependency-name: typescript
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@vsafonkinvsafonkinvsafonkin approved these changes
@dmitry-shibanovdmitry-shibanovdmitry-shibanov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetikonline@vsafonkin@brcrista@dmitry-shibanov