fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(sdk): fix observability events not reaching the server - #63

Merged
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission
Mar 6, 2026
Merged

fix(sdk): fix observability events not reaching the server#63
abhinav-galileo merged 9 commits into
mainfrom
abhi/fix-observability-event-emission

Conversation

@abhinav-galileo

@abhinav-galileoabhinav-galileo commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses the issue where control execution stats do not appear reliably in the UI for local SDK runs (see sc-57369).

This PR now includes four fixes:

  • Dedicated EventBatcher worker loop: replaced caller-loop-dependent batching with a dedicated daemon worker thread + event loop, so flushing works consistently across sync callers, repeated asyncio.run(...), and async apps.
  • Single-owner flush execution: _flush_loop is now the sole owner of _flush() execution (signal-driven wakeups), avoiding fire-and-forget concurrent flush task races.
  • Graceful shutdown drain: shutdown now wakes the worker, drains pending/in-flight batches safely, and then stops/joins the worker thread, preventing silent event loss during shutdown.
  • Safer defaults for observability:
    • observability_enabled default changed to True
    • flush_interval default changed from 10.0 to 5.0 seconds

Test plan

  • make sdk-lint
  • make sdk-typecheck
  • make sdk-test (284 passed, 1 skipped)
  • Added/ran targeted regression test for shutdown race:
    • test_shutdown_drains_inflight_flush_without_data_loss
  • Manual verification: run a local example agent and confirm UI stats appear within ~5s

Three fixes for control execution stats not showing in the UI:
1. EventBatcher lazy-start: when init() is called from sync context,
the flush loop never started because no event loop was available.
Added _try_attach_loop() called from add_event() to lazily attach
to the running loop on first use in async context.
2. Enable observability by default: changed observability_enabled
default from False to True, matching the server-side default and
eliminating the most common setup foot-gun.
3. Reduce flush interval from 10s to 5s: matches the UI polling
interval and reduces event loss on short-lived test runs.
@codecov

codecovBot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.74534% with 31 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/observability.py80.37%31 Missing ⚠️

📢 Thoughts on this report? Let us know!

sync_wrapper uses asyncio.run() per invocation, which creates and
closes a loop each call. EventBatcher only checked _loop is None,
so a closed-but-non-None loop was treated as healthy - flush tasks
silently died and events accumulated without being sent.
Fix _try_attach_loop() to detect closed loops via is_closed() and
reattach to the current running loop. Move all loop lifecycle logic
under _lock to eliminate the TOCTOU race on concurrent add_event()
calls. Clear stale state in _schedule_flush() on RuntimeError so
the next event can trigger reattachment.
Replace the lazy loop-attachment approach with a dedicated daemon
thread that owns its own event loop. This eliminates the entire
class of caller-loop lifecycle bugs (closed loops from asyncio.run,
sync-context init, TOCTOU races on reattachment).
- start() spawns a daemon thread running its own event loop
- Flush loop runs there independently of caller loops
- add_event() is a pure sync enqueue, no loop interaction
- shutdown() uses run_coroutine_threadsafe to flush remaining
events, then stops the loop and joins the thread
Tradeoff: one extra thread per batcher instance, but consistent
behavior across sync and async callers.
Comment threadsdks/python/src/agent_control/observability.py
Comment threadsdks/python/src/agent_control/observability.py Outdated
@abhinav-galileo
abhinav-galileo merged commit 70016db into mainMar 6, 2026
6 of 7 checks passed
@abhinav-galileo
abhinav-galileo deleted the abhi/fix-observability-event-emission branch March 6, 2026 14:42
galileo-automation pushed a commit that referenced this pull request Mar 11, 2026
## [1.1.0](ts-sdk-v1.0.1...ts-sdk-v1.1.0) (2026-03-11)
### Features
* **examples:** add Google ADK Agent Control examples ([#69](#69)) ([4b83542](4b83542))
* **infra:** publish UI image and add compose UI service ([#57](#57)) ([207c1af](207c1af))
* **sdk:** 57143 strands extra ([#59](#59)) ([97f2518](97f2518))
* **sdk:** add shutdown() and ashutdown() lifecycle API ([#70](#70)) ([9e29d86](9e29d86))
* **sdk:** migrate strands integration to be a plugin ([#74](#74)) ([897ece3](897ece3))
* **server:** enforce admin-only control-plane mutations ([#62](#62)) ([579407f](579407f)), closes [#61](#61)
* **ui:** serve exported Agent Control UI from the FastAPI server ([#71](#71)) ([c140198](c140198))
### Bug Fixes
* **docs:** add centered logo, header, and badges to README ([#92](#92)) ([39c3cbf](39c3cbf))
* **docs:** Test all examples ([#16](#16)) ([39e95c2](39e95c2))
* **evaluators:** migrate sqlglot rs extra to sqlglot c ([#86](#86)) ([5e3e48c](5e3e48c))
* **infra:** fix docker compose to make ui work ([#82](#82)) ([5edbb6b](5edbb6b))
* **infra:** Remove UI service from docker-compose.yml ([#91](#91)) ([330ef55](330ef55))
* **sdk): Revert "fix(sdk:** bundle evaluators in sdk wheel" ([#90](#90)) ([b516ea6](b516ea6)), closes [#89](#89)
* **sdk:** bundle evaluators in sdk wheel ([#89](#89)) ([ea5889a](ea5889a))
* **sdk:** fix observability events not reaching the server ([#63](#63)) ([70016db](70016db))
* **ui:** name update being saved now ([#87](#87)) ([919672d](919672d))
* **ui:** Step name not getting saved ([#68](#68)) ([13abef9](13abef9))
@galileo-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav-galileo@galileo-automation@siddhant-galileo@namrataghadi-galileo