Uh oh!
There was an error while loading. Please reload this page.
feat(gate): port origin-base dismissal into t3code factory gate - #240
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:66a32e7a4d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wizzoappBot
added a commit
that referenced
this pull request
Jul 30, 2026
Ports scripts/factory/{factory.conf,precommit-gate.sh} to the origin/main
version (landed via t3code #240) so the subsequent de-stale merge commit is
judged by an origin-base-capable gate. Byte-identical to origin/main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>adamfgr pushed a commit
that referenced
this pull request
Jul 30, 2026
* Sidebar v2 beta: flat thread list with a server-backed settled lifecycle (pingdotgg#4026) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> * feat(sidebar): reconcile settle inbox with subthreads * codex: address PR review feedback (#238) * codex: address second PR review (#238) * style(sidebar): keep light surface white * style(sidebar): match classic light surface * codex: address final PR review (#238) * fix(sidebar): cover split views and settled PR state * fix(orchestration): negotiate settlement replays * fix(threads): address 3 P2 review findings on settle sidebar v2 - mobile v2 list: build from the parent/child tree before splitting settled groups so mixed subthread trees stay grouped through settlement (matches web v2 inbox behaviour) - mobile v2 list: thread selectedThreadKey through the builder so a selected settled row beyond the first page stays visible on iPad/split - orchestration: reject settle when latestTurn.state === "running", not just an active session; mirror the guard in client canSettle/effectiveSettled Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix settlement attention blockers * Fix settle sidebar guard parity * Centralize thread attention settle blockers * Align sidebar v2 attention handling * chore(factory): adopt origin-base gate ahead of origin/main de-stale Ports scripts/factory/{factory.conf,precommit-gate.sh} to the origin/main version (landed via t3code #240) so the subsequent de-stale merge commit is judged by an origin-base-capable gate. Byte-identical to origin/main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: wizzoapp[bot] <254688279+wizzoapp[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References factory2 #18: https://github.com/agriffiths-bots/factory2/pull/18.
Unblocks #239's de-stale by allowing audited inherited fork-base findings from origin/main.
ADA-205 tracks the shared P2 around non-string origin-base notes; this port keeps the logic byte-aligned with factory2 pending that fix.
Verification