Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/factory/factory.conf
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ FACTORY_REVIEW_ARGS=(
# Ref used to structurally verify "upstream-origin" dismissals: a dismissal is
# only accepted when the staged blob is byte-identical to this ref's blob.
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF="origin/main"

# Audit log (JSONL, appended) for every gate decision, dismissal, and skip.
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
Expand Down
22 changes: 21 additions & 1 deletion scripts/factory/precommit-gate.sh
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,12 +28,17 @@
# even in the same file):
# [{"file":"apps/x.ts","line":42,"title":"<exact finding title>",
# "reason":"upstream-origin","note":"optional"},
# {"file":"apps/base.ts","line":12,"title":"<exact finding title>",
# "reason":"origin-base","note":"<required inherited-base note>"},
# {"file":"apps/y.ts","line":7,"title":"<exact finding title>",
# "reason":"false-positive","justification":"<why the finding is wrong,
# verified against the real code — min 120 chars>"}]
# * upstream-origin — accepted ONLY if the staged blob is byte-identical to
# FACTORY_UPSTREAM_REF:<file> (the code verbatim is upstream's, merged
# deliberately; upstream's design choices are not this commit's bugs).
# * origin-base — accepted ONLY when FACTORY_ORIGIN_REF is configured, the
# staged blob is byte-identical to FACTORY_ORIGIN_REF:<file>, and note is
# non-empty
# * false-positive — accepted only with a >=120-char justification naming
# the code-level reason. The PR merge gate (CI + Codex bound to HEAD) is
# untouched and remains the hard backstop for anything dismissed here.
Expand DownExpand Up@@ -109,6 +114,7 @@ FACTORY_STATIC_CHECKS_PARALLEL=0
FACTORY_REVIEW_ARGS=()
FACTORY_AUTOREVIEW_BIN="$HOME/.claude/skills/autoreview/scripts/autoreview"
FACTORY_UPSTREAM_REF="upstream/main"
FACTORY_ORIGIN_REF=""
FACTORY_AUDIT_LOG="$HOME/.openclaw/audit/factory-precommit.jsonl"
FACTORY_REVIEW_MEMORY_FINDINGS=15
# Config problems are RECORDED here and enforced after the --status /
Expand DownExpand Up@@ -628,12 +634,25 @@ if [ -f "$DISMISSALS" ] && jq -e 'type=="array"' "$DISMISSALS" >/dev/null 2>&1;
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$upstream_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_UPSTREAM_REF:$file — the code is (at least partly) ours, so the finding must be fixed or dismissed as false-positive with a justification"; fi
;;
origin-base)
note_len="$(jq -r '(.note // "") | length' <<<"$d")"
if [ -z "${FACTORY_ORIGIN_REF:-}" ]; then
why="origin-base dismissal for $file requires FACTORY_ORIGIN_REF to be configured"
elif [ "$note_len" -eq 0 ]; then
why="origin-base dismissal for $file needs a non-empty note explaining the inherited fork-base debt"
Comment thread
wizzoapp[bot] marked this conversation as resolved.
else
staged_blob="$(git rev-parse -q --verify ":$file" 2>/dev/null || true)"
origin_blob="$(git rev-parse -q --verify "$FACTORY_ORIGIN_REF:$file" 2>/dev/null || true)"
if [ -n "$staged_blob" ] && [ "$staged_blob" = "$origin_blob" ]; then ok=1
else why="staged $file is NOT byte-identical to $FACTORY_ORIGIN_REF:$file — the code is inherited fork-base debt only if it matches that ref, so the finding must be fixed or dismissed as false-positive with a justification"; fi
fi
;;
false-positive)
jlen="$(jq -r '(.justification // "") | length' <<<"$d")"
if [ "$jlen" -ge 120 ]; then ok=1
else why="false-positive dismissal for $file needs a justification of >=120 chars (has $jlen) naming the code-level reason the finding is wrong"; fi
;;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | false-positive)";;
*) why="unknown dismissal reason '$reason' for $file (use upstream-origin | origin-base | false-positive)";;
esac
if [ "$ok" -eq 1 ]; then
valid_dismissals="$(jq -c --argjson d "$d" --arg f "$file" \
Expand DownExpand Up@@ -666,6 +685,7 @@ cat >&2 <<EOF
Next steps (in order of preference):
1. FIX the findings, git add -A, and retry (full report: $REVIEW_JSON).
2. If a finding is in code that is verbatim upstream's ($FACTORY_UPSTREAM_REF)
or verbatim fork-base code ($FACTORY_ORIGIN_REF, when configured; note required)
or is demonstrably wrong, write $DISMISSALS —
schema in the header of scripts/factory/precommit-gate.sh. Each entry must
copy the finding's exact file, line, and title from the report above.
Expand Down
Loading