Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Relieve the version requirements of faraday gem to use faraday-1.x - #27
Closed
9toon wants to merge 6 commits into
Closed
Relieve the version requirements of faraday gem to use faraday-1.x #279toon wants to merge 6 commits into
9toon wants to merge 6 commits into
Conversation
9toonforce-pushed
the
feature/support-faraday-1.0
branch
2 times, most recently
from
February 23, 2021 08:28
3f0f16a to
5adf88eCompare9toonforce-pushed
the
feature/support-faraday-1.0
branch
from
February 23, 2021 08:28
5adf88e to
4baea0aCompare9toonforce-pushed
the
feature/support-faraday-1.0
branch
from
February 23, 2021 09:03
fc4df86 to
b2bb4aeCompare9toonforce-pushed
the
feature/support-faraday-1.0
branch
from
February 23, 2021 09:29
030110f to
a94ce5cCompare9toon
commented
Feb 23, 2021
Author
oops, I realized that faraday 1.x only supports Ruby 2.3 or later!! 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains these changes.
Concerns
Migrating faraday 0.8 to 1.x has significant breaking changes.
ref: https://github.com/lostisland/faraday/blob/master/UPGRADING.md#faraday-10
Should we upgrade hypernova-ruby to 2.0?
If so, I think we can drop support for old Ruby versions reached to EOL for easy maintenance.
For instance, json-1.8 gem which hypernova-ruby uses produces a deprecated warning on Ruby 2.7. But json-2.x doesn't support Ruby 1.9.
ref: https://github.com/flori/json/blob/v2.5.1/json.gemspec#L68