Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Update to Faraday 1.0 - #28

Open
9toon wants to merge 5 commits into
airbnb:masterfrom
9toon:feature/support-faraday-1.0-mojor-upgrade
Open

Update to Faraday 1.0#28
9toon wants to merge 5 commits into
airbnb:masterfrom
9toon:feature/support-faraday-1.0-mojor-upgrade

Conversation

@9toon

@9toon9toon commented Feb 28, 2021

Copy link
Copy Markdown

As the PR #27 I sent a before, Migrating Faraday to 1.x has significant changes.
So, I suggest to update the old dependencies and the supported Ruby versions in order to meet the recent development circumstances.

I think this gem is great, but it blocks updating the other gems which dependent to Faraday in my projects.

This change needs a major update, would you consider it?

ref: https://github.com/lostisland/faraday/blob/master/UPGRADING.md

@ehlertij

ehlertij commented Jun 16, 2021

Copy link
Copy Markdown

My project also requires faraday > 1.0. Any chance this could get a version cut?

@torrocus

torrocus commented Jul 6, 2022•
edited
Loading

Copy link
Copy Markdown

Dear @airbnb developers!
Is there a slim chance that this PR will be merged anytime soon? Since it is difficult to determine who of the contributors is still working in AirBnb, I mention a few people.
@goatslacker@100@a15n@indiesquidge@keeleysam@lencioni@tobymao

Sorry for the shout, but this PR has been waiting for over a year without any answer. It will be nice of you if something moves on this matter. If you need help, let me know too. Thank you in advance.

@henriquesml

henriquesml commented Aug 12, 2022

Copy link
Copy Markdown

image

@voigtito

voigtito commented Aug 12, 2022

Copy link
Copy Markdown

up

pedroida
pedroida approved these changes Aug 12, 2022
View reviewed changes

@pedroidapedroida left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvitormichels

This comment was marked as spam.

Sign in to view
LuizKraisch
LuizKraisch approved these changes Aug 12, 2022
View reviewed changes

@LuizKraischLuizKraisch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't if I should approve this? (they asked me to do that) but okay :))

@erik-tomelin

This comment was marked as spam.

Sign in to view
@ljharb

ljharb commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml)

@torrocus

torrocus commented Aug 15, 2022

Copy link
Copy Markdown

Spam PR approvals from non-maintainers will decrease, not increase, the PR's chances of being landed. (cc @henriquesml)

@ljharb You are right, it's not a commendable behavior. I'm concerned that this project has been abandoned, even though many people are still using it. Lack of any information from the owners is perhaps the worst possible thing. What can we do to help?

@ljharb

ljharb commented Aug 15, 2022

Copy link
Copy Markdown
Collaborator

I doubt there’s anything to be done but wait patiently.

@torrocus

torrocus commented Sep 7, 2022•
edited
Loading

Copy link
Copy Markdown

I doubt there’s anything to be done but wait patiently.

@ljharb May I kindly ask what amount of patience is needed for some @airbnb developer to merge these changes? I would like to point out that this is over a year and a half. This project looks abandoned.

@diclophis

diclophis commented Dec 9, 2022

Copy link
Copy Markdown

LGTM, let's go for merge!

RuiPMoreira
RuiPMoreira approved these changes Jan 24, 2023
View reviewed changes

@RuiPMoreiraRuiPMoreira left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, this project is stuck in time and we need this change

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

22 more reviewers
@danilopinottidanilopinottidanilopinotti approved these changes
@oAddsonoAddsonoAddson approved these changes
@pedroidapedroidapedroida approved these changes
@RuiPMoreiraRuiPMoreiraRuiPMoreira approved these changes
@Matheus-MazepaMatheus-MazepaMatheus-Mazepa approved these changes
@GUIFRE88GUIFRE88GUIFRE88 approved these changes
@absimaoabsimaoabsimao approved these changes
@henriquesmlhenriquesmlhenriquesml approved these changes
@AdrianeRibeiroAdrianeRibeiroAdrianeRibeiro approved these changes
@LuizKraischLuizKraischLuizKraisch approved these changes
@gabilizgabilizgabiliz approved these changes
@efsiqueiraefsiqueiraefsiqueira approved these changes
@voigtitovoigtitovoigtito approved these changes
@EduardoJesusxEduardoJesusxEduardoJesusx approved these changes
@ViniciusLisboa07ViniciusLisboa07ViniciusLisboa07 approved these changes
@xandegrawexandegrawexandegrawe approved these changes
@jvitormichelsjvitormichelsjvitormichels approved these changes
@LuisMSAmorimLuisMSAmorimLuisMSAmorim approved these changes
@KanamyDamiaoKanamyDamiaoKanamyDamiao approved these changes
@lucasarsartorilucasarsartorilucasarsartori approved these changes
@gxoliveigxoliveigxolivei approved these changes
@Luiza-CamargoLuiza-CamargoLuiza-Camargo approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

20 participants

@9toon@ehlertij@torrocus@henriquesml@voigtito@jvitormichels@erik-tomelin@ljharb@diclophis@danilopinotti@oAddson@pedroida@RuiPMoreira@Matheus-Mazepa@GUIFRE88@absimao@AdrianeRibeiro@LuizKraisch@gabiliz@efsiqueira