') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content

Add tethering tests - #36

Merged
EddyTheCo merged 2 commits into
amarula:developfrom
EddyTheCo:add_tethering_tests
May 14, 2026
Merged

Add tethering tests#36
EddyTheCo merged 2 commits into
amarula:developfrom
EddyTheCo:add_tethering_tests

Conversation

@EddyTheCo

@EddyTheCoEddyTheCo commented May 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@EddyTheCo
gconnman_technology.cpp: Use int32 for freq variant
81f5b70
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
@EddyTheCo
gconnman_tech_test.cpp: Add tethering tests
18aabe1
Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
gemini-code-assist[bot]
gemini-code-assistBot reviewed May 14, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tethering frequency setter to use a signed 32-bit integer variant and introduces new unit tests for enabling and disabling tethering. The review feedback highlights a type mismatch in the frequency setter, the incorrect use of assertion macros within asynchronous lambdas, potential race conditions in the test execution flow, and the need for better handling of environment-specific hardware dependencies in tests.

Comment threadsrc/dbus/gconnman_technology.cpp
Comment threadtests/gconnman_tech_test.cpp
Comment threadtests/gconnman_tech_test.cpp
Comment threadtests/gconnman_tech_test.cpp
}
});
}
ASSERT_TRUE(called) << "setTethering callback was never called";

@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.

@github-actions

github-actionsBot commented May 14, 2026

Copy link
Copy Markdown

🧩 Build Artifacts

✅ The following build artifacts were produced:

github-actions[bot]
github-actionsBot reviewed May 14, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

Comment threadsrc/dbus/gconnman_technology.cpp
@EddyTheCoEddyTheCo mentioned this pull request May 14, 2026
Closed
@EddyTheCo
EddyTheCo merged commit b5e8571 into amarula:developMay 14, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EddyTheCo