Skip to content

Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EddyTheCo merged 2 commits into from
May 14, 2026
Merged

Add tethering tests #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81f5b70
gconnman_technology.cpp: Use int32 for freq variant
EddyTheCo May 14, 2026
18aabe1
gconnman_tech_test.cpp: Add tethering tests
EddyTheCo May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/dbus/gconnman_technology.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
PropertiesSetCallback callback) {
auto data = prepareCallback(std::move(callback));
setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.
Comment thread
EddyTheCo marked this conversation as resolved.
&Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
name_ = g_variant_get_string(value, nullptr);
} else if (g_strcmp0(key, TYPE_STR) == 0U) {
type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

} else if (g_strcmp0(key, POWERED_STR) == 0U) {
powered_ = g_variant_get_boolean(value) == 1U;
} else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down
109 changes: 109 additions & 0 deletions tests/gconnman_tech_test.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
bool called = false;
{
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
bool called = false;
{
const ThreadBundle thread_bundle;
Connman connman;
const auto manager = connman.manager();

manager->onTechnologiesChanged(
[&called, main_tid = thread_bundle.main_tid,
loop_tid = thread_bundle.loop_tid](const auto& technologies) {
ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.
<< "No technologies returned";

for (const auto& tech : technologies) {
const auto props = tech->properties();
const auto name = props.getName();

if (props.getType() == Type::Wifi) { // test only wifi
std::cout << "Setting tethering properties for " << name
<< "\n";
tech->setTetheringIdentifier(
"AmarulaTestSSID",
[name, main_tid, loop_tid](bool success) {
const auto callback_tid =
std::this_thread::get_id();
EXPECT_NE(callback_tid, main_tid);
EXPECT_NE(callback_tid, loop_tid);
EXPECT_TRUE(success)
<< "Failed to set tethering identifier for "
<< name;
});
tech->setTetheringPassphrase(
"AmarulaTestPassphrase",
[name, main_tid, loop_tid](bool success) {
const auto callback_tid =
std::this_thread::get_id();
EXPECT_NE(callback_tid, main_tid);
EXPECT_NE(callback_tid, loop_tid);
EXPECT_TRUE(success)
<< "Failed to set tethering passphrase for "
<< name;
});

tech->setTetheringFreq(
WIFI_FREQ_2412_MHZ,
[name, main_tid, loop_tid](bool success) {
const auto callback_tid =
std::this_thread::get_id();
EXPECT_NE(callback_tid, main_tid);
EXPECT_NE(callback_tid, loop_tid);
EXPECT_TRUE(success)
<< "Failed to set tethering frequency for "
<< name;
});
tech->setTethering(true, [&called, name, main_tid,
loop_tid](bool success) {
const auto callback_tid =
std::this_thread::get_id();
EXPECT_NE(callback_tid, main_tid);
EXPECT_NE(callback_tid, loop_tid);
EXPECT_TRUE(success)
<< "Failed to set tethering for " << name;
called = true;
});
Comment thread
EddyTheCo marked this conversation as resolved.
}
}
});
}
ASSERT_TRUE(called) << "setTethering callback was never called";

@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.

}

TEST(Connman, SetTetheringOff) {
bool called = false;
{
const ThreadBundle thread_bundle;
Connman connman;
const auto manager = connman.manager();

manager->onTechnologiesChanged(
[&called, main_tid = thread_bundle.main_tid,
loop_tid = thread_bundle.loop_tid](const auto& technologies) {
ASSERT_FALSE(technologies.empty())
<< "No technologies returned";

for (const auto& tech : technologies) {
const auto props = tech->properties();
const auto name = props.getName();

if (props.getType() == Type::Wifi) { // test only wifi
std::cout << "Disable tethering for " << name << "\n";
tech->setTethering(false, [&called, name, main_tid,
loop_tid](bool success) {
const auto callback_tid =
std::this_thread::get_id();
EXPECT_NE(callback_tid, main_tid);
EXPECT_NE(callback_tid, loop_tid);
EXPECT_TRUE(success)
<< "Failed to unset tethering for " << name;
called = true;
});
}
}
});
}
ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
bool called = false;
{
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content
Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

EddyTheCo
merged 2 commits into

from

May 14, 2026
 Merged


Add tethering tests
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
81f5b70

gconnman_technology.cpp: Use int32 for freq variant


EddyTheCo May 14, 2026
18aabe1

gconnman_tech_test.cpp: Add tethering tests


EddyTheCo May 14, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
src/dbus/gconnman_technology.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
 PropertiesSetCallback callback) {
 auto data = prepareCallback(std::move(callback));
 setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
 setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.

Comment thread
EddyTheCo marked this conversation as resolved.

 &Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
 name_ = g_variant_get_string(value, nullptr);
 } else if (g_strcmp0(key, TYPE_STR) == 0U) {
 type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

 } else if (g_strcmp0(key, POWERED_STR) == 0U) {
 powered_ = g_variant_get_boolean(value) == 1U;
 } else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down

109 changes: 109 additions & 0 deletions
tests/gconnman_tech_test.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
 bool called = false;
 {
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
 ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.

 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Setting tethering properties for " << name
 << "\n";
 tech->setTetheringIdentifier(
 "AmarulaTestSSID",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering identifier for "
 << name;
 });
 tech->setTetheringPassphrase(
 "AmarulaTestPassphrase",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering passphrase for "
 << name;
 });

 tech->setTetheringFreq(
 WIFI_FREQ_2412_MHZ,
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering frequency for "
 << name;
 });
 tech->setTethering(true, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering for " << name;
 called = true;
 });
Comment thread
EddyTheCo marked this conversation as resolved.

 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
}

TEST(Connman, SetTetheringOff) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Disable tethering for " << name << "\n";
 tech->setTethering(false, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to unset tethering for " << name;
 called = true;
 });
 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
 bool called = false;
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content
Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

EddyTheCo
merged 2 commits into

from

May 14, 2026
 Merged


Add tethering tests
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
81f5b70

gconnman_technology.cpp: Use int32 for freq variant


EddyTheCo May 14, 2026
18aabe1

gconnman_tech_test.cpp: Add tethering tests


EddyTheCo May 14, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
src/dbus/gconnman_technology.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
 PropertiesSetCallback callback) {
 auto data = prepareCallback(std::move(callback));
 setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
 setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.

Comment thread
EddyTheCo marked this conversation as resolved.

 &Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
 name_ = g_variant_get_string(value, nullptr);
 } else if (g_strcmp0(key, TYPE_STR) == 0U) {
 type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

 } else if (g_strcmp0(key, POWERED_STR) == 0U) {
 powered_ = g_variant_get_boolean(value) == 1U;
 } else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down

109 changes: 109 additions & 0 deletions
tests/gconnman_tech_test.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
 bool called = false;
 {
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
 ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.

 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Setting tethering properties for " << name
 << "\n";
 tech->setTetheringIdentifier(
 "AmarulaTestSSID",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering identifier for "
 << name;
 });
 tech->setTetheringPassphrase(
 "AmarulaTestPassphrase",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering passphrase for "
 << name;
 });

 tech->setTetheringFreq(
 WIFI_FREQ_2412_MHZ,
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering frequency for "
 << name;
 });
 tech->setTethering(true, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering for " << name;
 called = true;
 });
Comment thread
EddyTheCo marked this conversation as resolved.

 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
}

TEST(Connman, SetTetheringOff) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Disable tethering for " << name << "\n";
 tech->setTethering(false, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to unset tethering for " << name;
 called = true;
 });
 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
 bool called = false;
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content
Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

EddyTheCo
merged 2 commits into

from

May 14, 2026
 Merged


Add tethering tests
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
81f5b70

gconnman_technology.cpp: Use int32 for freq variant


EddyTheCo May 14, 2026
18aabe1

gconnman_tech_test.cpp: Add tethering tests


EddyTheCo May 14, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
src/dbus/gconnman_technology.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
 PropertiesSetCallback callback) {
 auto data = prepareCallback(std::move(callback));
 setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
 setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.

Comment thread
EddyTheCo marked this conversation as resolved.

 &Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
 name_ = g_variant_get_string(value, nullptr);
 } else if (g_strcmp0(key, TYPE_STR) == 0U) {
 type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

 } else if (g_strcmp0(key, POWERED_STR) == 0U) {
 powered_ = g_variant_get_boolean(value) == 1U;
 } else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down

109 changes: 109 additions & 0 deletions
tests/gconnman_tech_test.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
 bool called = false;
 {
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
 ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.

 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Setting tethering properties for " << name
 << "\n";
 tech->setTetheringIdentifier(
 "AmarulaTestSSID",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering identifier for "
 << name;
 });
 tech->setTetheringPassphrase(
 "AmarulaTestPassphrase",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering passphrase for "
 << name;
 });

 tech->setTetheringFreq(
 WIFI_FREQ_2412_MHZ,
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering frequency for "
 << name;
 });
 tech->setTethering(true, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering for " << name;
 called = true;
 });
Comment thread
EddyTheCo marked this conversation as resolved.

 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
}

TEST(Connman, SetTetheringOff) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Disable tethering for " << name << "\n";
 tech->setTethering(false, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to unset tethering for " << name;
 called = true;
 });
 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
 bool called = false;
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content
Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

EddyTheCo
merged 2 commits into

from

May 14, 2026
 Merged


Add tethering tests
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
81f5b70

gconnman_technology.cpp: Use int32 for freq variant


EddyTheCo May 14, 2026
18aabe1

gconnman_tech_test.cpp: Add tethering tests


EddyTheCo May 14, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
src/dbus/gconnman_technology.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
 PropertiesSetCallback callback) {
 auto data = prepareCallback(std::move(callback));
 setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
 setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.

Comment thread
EddyTheCo marked this conversation as resolved.

 &Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
 name_ = g_variant_get_string(value, nullptr);
 } else if (g_strcmp0(key, TYPE_STR) == 0U) {
 type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

 } else if (g_strcmp0(key, POWERED_STR) == 0U) {
 powered_ = g_variant_get_boolean(value) == 1U;
 } else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down

109 changes: 109 additions & 0 deletions
tests/gconnman_tech_test.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
 bool called = false;
 {
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
 ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.

 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Setting tethering properties for " << name
 << "\n";
 tech->setTetheringIdentifier(
 "AmarulaTestSSID",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering identifier for "
 << name;
 });
 tech->setTetheringPassphrase(
 "AmarulaTestPassphrase",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering passphrase for "
 << name;
 });

 tech->setTetheringFreq(
 WIFI_FREQ_2412_MHZ,
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering frequency for "
 << name;
 });
 tech->setTethering(true, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering for " << name;
 called = true;
 });
Comment thread
EddyTheCo marked this conversation as resolved.

 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
}

TEST(Connman, SetTetheringOff) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Disable tethering for " << name << "\n";
 tech->setTethering(false, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to unset tethering for " << name;
 called = true;
 });
 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
 bool called = false;
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content
Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

EddyTheCo
merged 2 commits into

from

May 14, 2026
 Merged


Add tethering tests
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
81f5b70

gconnman_technology.cpp: Use int32 for freq variant


EddyTheCo May 14, 2026
18aabe1

gconnman_tech_test.cpp: Add tethering tests


EddyTheCo May 14, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
src/dbus/gconnman_technology.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
 PropertiesSetCallback callback) {
 auto data = prepareCallback(std::move(callback));
 setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
 setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.

Comment thread
EddyTheCo marked this conversation as resolved.

 &Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
 name_ = g_variant_get_string(value, nullptr);
 } else if (g_strcmp0(key, TYPE_STR) == 0U) {
 type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

 } else if (g_strcmp0(key, POWERED_STR) == 0U) {
 powered_ = g_variant_get_boolean(value) == 1U;
 } else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down

109 changes: 109 additions & 0 deletions
tests/gconnman_tech_test.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
 bool called = false;
 {
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
 ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.

 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Setting tethering properties for " << name
 << "\n";
 tech->setTetheringIdentifier(
 "AmarulaTestSSID",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering identifier for "
 << name;
 });
 tech->setTetheringPassphrase(
 "AmarulaTestPassphrase",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering passphrase for "
 << name;
 });

 tech->setTetheringFreq(
 WIFI_FREQ_2412_MHZ,
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering frequency for "
 << name;
 });
 tech->setTethering(true, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering for " << name;
 called = true;
 });
Comment thread
EddyTheCo marked this conversation as resolved.

 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
}

TEST(Connman, SetTetheringOff) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Disable tethering for " << name << "\n";
 tech->setTethering(false, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to unset tethering for " << name;
 called = true;
 });
 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
 bool called = false;
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Add tethering tests by EddyTheCo · Pull Request #36 · amarula/libcppconnman · GitHub
Skip to content
Add tethering tests#36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

EddyTheCo
merged 2 commits into

from

May 14, 2026
 Merged


Add tethering tests
#36
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
81f5b70

gconnman_technology.cpp: Use int32 for freq variant


EddyTheCo May 14, 2026
18aabe1

gconnman_tech_test.cpp: Add tethering tests


EddyTheCo May 14, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 1 addition & 2 deletions
src/dbus/gconnman_technology.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,7 +60,7 @@ void Technology::setTetheringPassphrase(const std::string& passphrase,
void Technology::setTetheringFreq(const uint32_t frequency,
 PropertiesSetCallback callback) {
 auto data = prepareCallback(std::move(callback));
 setProperty(TETHERINGFREQ_STR, g_variant_new_uint32(frequency), nullptr,
 setProperty(TETHERINGFREQ_STR, g_variant_new_int32(frequency), nullptr,
Comment thread
EddyTheCo marked this conversation as resolved.

Comment thread
EddyTheCo marked this conversation as resolved.

 &Technology::finishAsyncCall, data.release());
}

Expand All@@ -75,7 +75,6 @@ void TechProperties::update(const gchar* key, GVariant* value) {
 name_ = g_variant_get_string(value, nullptr);
 } else if (g_strcmp0(key, TYPE_STR) == 0U) {
 type_ = TYPE_MAP.fromString(g_variant_get_string(value, nullptr));

 } else if (g_strcmp0(key, POWERED_STR) == 0U) {
 powered_ = g_variant_get_boolean(value) == 1U;
 } else if (g_strcmp0(key, CONNECTED_STR) == 0U) {
Expand Down

109 changes: 109 additions & 0 deletions
tests/gconnman_tech_test.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,8 @@
using Amarula::DBus::G::Connman::Connman;
using Type = Amarula::DBus::G::Connman::TechProperties::Type;

constexpr uint32_t WIFI_FREQ_2412_MHZ = 2412;

TEST(Connman, getTechs) {
 bool called = false;
 {
Expand DownExpand Up@@ -125,6 +127,113 @@ TEST(Connman, ScanWifiTechnology) {
 ASSERT_TRUE(called) << "TechnologiesChanged callback was never called";
}

TEST(Connman, SetTetheringOn) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
Comment thread
EddyTheCo marked this conversation as resolved.

 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Setting tethering properties for " << name
 << "\n";
 tech->setTetheringIdentifier(
 "AmarulaTestSSID",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering identifier for "
 << name;
 });
 tech->setTetheringPassphrase(
 "AmarulaTestPassphrase",
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering passphrase for "
 << name;
 });

 tech->setTetheringFreq(
 WIFI_FREQ_2412_MHZ,
 [name, main_tid, loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering frequency for "
 << name;
 });
 tech->setTethering(true, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to set tethering for " << name;
 called = true;
 });
Comment thread
EddyTheCo marked this conversation as resolved.

 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
@gemini-code-assistgemini-code-assistBotMay 14, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
This assertion will fail if no Wifi technology is found on the system, as called will remain false. This makes the test suite dependent on the host environment's hardware configuration. Consider checking for the existence of a Wifi technology and skipping the test (or marking it as successful/inconclusive) if none is found, rather than failing.
}

TEST(Connman, SetTetheringOff) {
 bool called = false;
 {
 const ThreadBundle thread_bundle;
 Connman connman;
 const auto manager = connman.manager();

 manager->onTechnologiesChanged(
 [&called, main_tid = thread_bundle.main_tid,
 loop_tid = thread_bundle.loop_tid](const auto& technologies) {
 ASSERT_FALSE(technologies.empty())
 << "No technologies returned";

 for (const auto& tech : technologies) {
 const auto props = tech->properties();
 const auto name = props.getName();

 if (props.getType() == Type::Wifi) { // test only wifi
 std::cout << "Disable tethering for " << name << "\n";
 tech->setTethering(false, [&called, name, main_tid,
 loop_tid](bool success) {
 const auto callback_tid =
 std::this_thread::get_id();
 EXPECT_NE(callback_tid, main_tid);
 EXPECT_NE(callback_tid, loop_tid);
 EXPECT_TRUE(success)
 << "Failed to unset tethering for " << name;
 called = true;
 });
 }
 }
 });
 }
 ASSERT_TRUE(called) << "setTethering callback was never called";
}

TEST(Connman, PowerOffAllTechnologies) {
 bool called = false;
 {
Expand Down
Loading