Skip to content

chore: bump to 6.0.0-beta.6 and remove explicit preserveWhitespaces setting - #10216

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:preserve-whitespaces-no-more
Mar 6, 2018
Merged

chore: bump to 6.0.0-beta.6 and remove explicit preserveWhitespaces setting#10216
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:preserve-whitespaces-no-more

Conversation

@crisbeto

@crisbetocrisbeto commented Mar 1, 2018

Copy link
Copy Markdown
Member
  • Bumps the Angular version to at least 6.0.0-beta.6.
  • Removes all of the preserveWhitespaces declarations, because the option is now false by default.
  • Removes the tslint requirement for preserveWhitespaces.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2018
@crisbeto
chore: bump to 6.0.0-beta.6 and remove explicit preserveWhitespaces s…
02d5736
…etting
* Bumps the Angular version to at least 6.0.0-beta.6.
* Removes all of the `preserveWhitespaces` declarations, because the option is now `false` by default.
* Removes the tslint requirement for `preserveWhitespaces`.
@crisbeto
crisbetoforce-pushed the preserve-whitespaces-no-more branch from 0ae9418 to 02d5736CompareMarch 2, 2018 21:05
amcdnl
amcdnl approved these changes Mar 4, 2018
View reviewed changes

@amcdnlamcdnl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerbammalerba added pr: lgtm target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 5, 2018
jelbourn
jelbourn approved these changes Mar 5, 2018
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2018
@jelbourn
jelbourn merged commit 8830486 into angular:masterMar 6, 2018
@rafaelss95rafaelss95 mentioned this pull request Apr 8, 2018
Merged
@devversiondevversion mentioned this pull request Jul 6, 2018
Merged
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 8, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 8, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguinandrewseguinAwaiting requested review from andrewseguin
@devversiondevversionAwaiting requested review from devversion
@josephperrottjosephperrottAwaiting requested review from josephperrott
@karakaraAwaiting requested review from kara
@tinayuangaotinayuangaoAwaiting requested review from tinayuangao
3 more reviewers
@amcdnlamcdnlamcdnl approved these changes
@jelbournjelbournjelbourn approved these changes
@mmalerbammalerbammalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbournjelbourn

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: majorThis PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto@amcdnl@jelbourn@mmalerba@googlebot