Skip to content

chore(calendar): remove explicit preserveWhitespaces setting - #10761

Merged
tinayuangao merged 1 commit into
angular:masterfrom
rafaelss95:fix-explicit-preserve-whitespaces
Apr 11, 2018
Merged

chore(calendar): remove explicit preserveWhitespaces setting#10761
tinayuangao merged 1 commit into
angular:masterfrom
rafaelss95:fix-explicit-preserve-whitespaces

Conversation

@rafaelss95

@rafaelss95rafaelss95 commented Apr 8, 2018

Copy link
Copy Markdown
Contributor

The explicit preserveWhitespaces setting were removed in #10216, but #9639 added it to a new component (MatCalendarHeader). To prevent future mistakes like that I've added "!preserveWhitespaces": ".*" to the validate-decorators rule in tslint.json.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 8, 2018

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 9, 2018
@josephperrottjosephperrott added target: patch This PR is targeted for the next patch release and removed pr: merge safe labels Apr 9, 2018
@josephperrott

Copy link
Copy Markdown
Member

Removing merge safe as this could potentially have downstream effects. But it should be fine.

@tinayuangao
tinayuangao merged commit 34fe17e into angular:masterApr 11, 2018
@rafaelss95
rafaelss95 deleted the fix-explicit-preserve-whitespaces branch April 12, 2018 00:42
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 8, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@rafaelss95@josephperrott@crisbeto@googlebot@tinayuangao