Uh oh!
There was an error while loading. Please reload this page.
fix(checkbox): don't show hover ripples on touch devices - #13700
Merged
jelbourn merged 1 commit intoMay 13, 2019
Conversation
crisbeto
requested review from
devversion, jelbourn and josephperrott
as code ownersOctober 20, 2018 07:51
This was referenced Oct 20, 2018
crisbetoforce-pushed
the
13675/checkbox-touch-hover-ripples
branch
from
October 20, 2018 10:17
31d4564 to
4f52c4fCompare
|
crisbetoforce-pushed
the
13675/checkbox-touch-hover-ripples
branch
from
March 3, 2019 17:41
4f52c4f to
bf830d3CompareOn touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples. Fixesangular#13675.
crisbetoforce-pushed
the
13675/checkbox-touch-hover-ripples
branch
from
May 8, 2019 14:34
bf830d3 to
192eb3fCompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On touch devices
:hoverstyling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples.Fixes#13675.