Skip to content

fix(radio): don't show hover ripples on touch devices - #13701

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13675/radio-hover-ripples
Oct 25, 2018
Merged

fix(radio): don't show hover ripples on touch devices#13701
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:13675/radio-hover-ripples

Conversation

@crisbeto

Copy link
Copy Markdown
Member

On touch devices :hover styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples.

Related to #13675.

Note: this is the same issue that is fixed in #13700. I'm splitting into separate PRs, because we're blocked on merging style changes for some components, for now.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 20, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 20, 2018
On touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples.
Related to angular#13675.
@crisbeto
crisbetoforce-pushed the 13675/radio-hover-ripples branch from 233126a to 60463a1CompareOctober 20, 2018 10:18

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 25, 2018
@mmalerba
mmalerba merged commit f230633 into angular:masterOct 25, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
On touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples.
Related to #13675.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
On touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples.
Related to angular#13675.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto@jelbourn@googlebot@mmalerba