Uh oh!
There was an error while loading. Please reload this page.
fix(expansion-panel): don't handle enter/space if modifier is pressed - #13790
Merged
mmalerba merged 1 commit intoOct 25, 2018
Merged
Conversation
Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys. Fixesangular#13783.
crisbeto
requested review from
devversion, jelbourn and josephperrott
as code ownersOctober 24, 2018 15:09
jelbourn
approved these changes
Oct 24, 2018
| case ENTER: | ||
| event.preventDefault(); | ||
| this._toggle(); | ||
| if (!event.altKey && !event.metaKey && !event.shiftKey && !event.ctrlKey) { |
Contributor
There was a problem hiding this comment.
Not in this PR, but we should think about adding some helper functions to cdk/keycodes for checking stuff like this
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Oct 26, 2018
Along the same lines as angular#13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 1, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 1, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 1, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 1, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 2, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 3, 2018
Based off of the conversation in angular#13790, these changes add some utilities for dealing with modifier keys on keyboard events.
atscott pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
…angular#13790) Doesn't `preventDefault` and handle the enter and space key presses if the user is pressing any of the modifier keys. Fixesangular#13783.
atscott pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
…ngular#13827) Along the same lines as angular#13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.
vivian-hu-zz pushed a commit
that referenced
this pull request
Nov 6, 2018
Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.
vivian-hu-zz pushed a commit
that referenced
this pull request
Nov 7, 2018
Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.
josephperrott pushed a commit
that referenced
this pull request
Nov 20, 2018
Based off of the conversation in #13790, these changes add some utilities for dealing with modifier keys on keyboard events.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't
preventDefaultand handle the enter and space key presses if the user is pressing any of the modifier keys.Fixes#13783.