Skip to content

fix(stepper): don't handle enter/space when modifier key is pressed - #13827

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:stepper-enter-modifiers
Oct 29, 2018
Merged

fix(stepper): don't handle enter/space when modifier key is pressed#13827
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:stepper-enter-modifiers

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Along the same lines as #13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.

Along the same lines as angular#13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 26, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2018
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 26, 2018
@jelbourn
jelbourn merged commit a9e550e into angular:masterOct 29, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
…ngular#13827)
Along the same lines as angular#13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
…13827)
Along the same lines as #13790. Doesn't handle the prevent the default action for ENTER and SPACE when one of the modifier keys is pressed, in order to avoid interefering with the native keyboard shortcuts.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto@jelbourn@googlebot@mmalerba