build: add tooling to avoid jit issues with empty NgModule definitions

[crisbeto]

• Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like fix(cdk-platform): pass {} to @NgModule since passing nothing breaks in JIT mode #13792.
• Fixes a similar issue as fix(cdk-platform): pass {} to @NgModule since passing nothing breaks in JIT mode #13792 in the LayoutModule which was caught after the new changes to the rule.

[devversion]

Didn't we chat about it just being something that should technically work, but we just have no idea how the given team ran into issues with it.

or did @mmalerba already get a response about why this happened?

[crisbeto]

I don't know whether @mmalerba got a response, but I added this tooling since it could spare us another random issue like #13792 in the future, while being fairly low maintenance.

[devversion]

I see, it just feels a bit odd to enforce something that is technically supported by Angular, but broke for someone potentially doing something unexpected we don't are aware of.

It would be just good to understand when it could break, and report an issue on Angular. I don't feel too strong about it.. the tooling shouldn't hurt either.

[josephperrott]

LGTM

[mmalerba]

I did talk to them, they mentioned that they might have had Ivy enabled at the time, but Misko didn't think it seemed like an Ivy issue. It's also possible it was a change Angular merged but didn't release yet, or maybe the team was just doing something really crazy. Whatever the reason, I don't think it hurts for us to specify the {}

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}