fix(material/menu): focus lost if active item is removed by crisbeto · Pull Request #14039 · angular/components

crisbeto · 2018-11-08T11:14:03Z

Fixes the user's focus being lost if the active item is destroyed while a menu is open.

crisbeto · 2018-11-08T11:14:19Z

Caretaker note: this might cause some unflushed timer errors in people's tests. Depending on the amount of presubmit issues, we could wait for #11720 to be merged which will allow us to remove the timer.

ngbot · 2018-11-27T15:55:41Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-11-27T15:56:49Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

jelbourn · 2018-12-04T23:23:23Z

I suspect adding the new async will break a large number of tests. If you rebase I can do a preliminary check to see.

crisbeto · 2018-12-05T18:59:43Z

Rebased @jelbourn.

Fixes the user's focus being lost if the active item is destroyed while a menu is open. Fixesangular#14028.

Fixes the user's focus being lost if the active item is destroyed while a menu is open. Fixes#14028. (cherry picked from commit dc4fbcf)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.4/13.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.4/13.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1325-satin-sash-2022-03-02) [Compare Source](angular/components@13.2.4...13.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [9e34a0f69f](angular/components@9e34a0f) | fix | **drag-drop:** error if preview dimensions are accessed too early ([#24498](angular/components#24498)) | | [9be3c46b01](angular/components@9be3c46) | fix | **testing:** TestElement sendKeys method should throw if no keys have been specified ([#18271](angular/components#18271)) | | [8e57a89cba](angular/components@8e57a89) | perf | **overlay:** add event listeners for overlay dispatchers outside of zone ([#24408](angular/components#24408)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [ed2f516401](angular/components@ed2f516) | fix | **autocomplete:** auto-highlighted first option not display correctly if the floating label is disabled ([#14507](angular/components#14507)) | | [502102116e](angular/components@5021021) | fix | **autocomplete:** don't block default arrow keys when using modifiers ([#11987](angular/components#11987)) | | [f31fd3f066](angular/components@f31fd3f) | fix | **autocomplete:** reopen panel on input click ([#16020](angular/components#16020)) | | [5a79042d7d](angular/components@5a79042) | fix | **button-toggle:** use solid border color ([#14253](angular/components#14253)) | | [e2d4eecfcb](angular/components@e2d4eec) | fix | **checkbox:** inconsistent disabled color ([#23083](angular/components#23083)) | | [005ec323de](angular/components@005ec32) | fix | **checkbox:** incorrect text color when placed inside an overlay with a dark theme ([#19054](angular/components#19054)) | | [d7cbd1315f](angular/components@d7cbd13) | fix | **datepicker:** matDatepickerParse error not being added on first invalid value ([#11524](angular/components#11524)) | | [046022f31d](angular/components@046022f) | fix | **datepicker:** use aria-live over cdkAriaLive on period button ([#24398](angular/components#24398)) | | [37f69dbf7e](angular/components@37f69db) | fix | **dialog:** use passed in ComponentFactoryResolver to resolve dialog content ([#17710](angular/components#17710)) | | [2e15f54a9f](angular/components@2e15f54) | fix | **menu:** focus lost if active item is removed ([#14039](angular/components#14039)) | | [ea07fa8e64](angular/components@ea07fa8) | fix | **progress-spinner:** unable to change mode on spinner directive ([#14514](angular/components#14514)) | | [1a498a6a81](angular/components@1a498a6) | fix | **sort:** remove role from header when disabled ([#24477](angular/components#24477)) | | [72019531db](angular/components@7201953) | fix | **tooltip:** don't hide when pointer moves to tooltip ([#24475](angular/components#24475)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [7b85cc077c](angular/components@7b85cc0) | fix | **mdc-button:** density styles being overwritten by structural styles ([#22736](angular/components#22736)) | | [aeb1426e4c](angular/components@aeb1426) | fix | **mdc-chips:** expose avatar harness ([#24499](angular/components#24499)) | #### Special Thanks Andrew Seguin, Artur Androsovych, Jeri Peier, Kristiyan Kostadinov, Paul Gschwendtner, Yousaf Nawaz and Zach Arend  </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1199 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-03-30T00:03:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added Accessibility This issue is related to accessibility (a11y) merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Nov 8, 2018

crisbeto assigned jelbourn Nov 8, 2018

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 8, 2018

crisbeto force-pushed the 14028/menu-item-swap-focus branch from 141b21e to 36ac000Compare November 27, 2018 17:51

crisbeto force-pushed the 14028/menu-item-swap-focus branch from 36ac000 to bcb9ad3Compare December 5, 2018 18:59

crisbeto force-pushed the 14028/menu-item-swap-focus branch from bcb9ad3 to fcbf76cCompare February 27, 2019 22:03

mmalerba added aaa and removed aaa labels Apr 25, 2019

andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019

crisbeto force-pushed the 14028/menu-item-swap-focus branch from fcbf76c to 65fcff4Compare June 2, 2019 08:40

crisbeto force-pushed the 14028/menu-item-swap-focus branch from 65fcff4 to c91ba96Compare October 5, 2019 11:45

crisbeto force-pushed the 14028/menu-item-swap-focus branch from c91ba96 to 48842caCompare March 20, 2020 22:30

andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021

andrewseguin added the needs rebase label Jan 19, 2022

crisbeto force-pushed the 14028/menu-item-swap-focus branch from 48842ca to 912e46fCompare February 26, 2022 17:20

crisbeto changed the title ~~fix(menu): focus lost if active item is removed~~fix(material/menu): focus lost if active item is removedFeb 26, 2022

crisbeto added action: merge The PR is ready for merge by the caretaker and removed needs rebase labels Feb 26, 2022

crisbeto force-pushed the 14028/menu-item-swap-focus branch 2 times, most recently from 1ea75b9 to 93fadb2Compare February 27, 2022 15:30

fix(material/menu): focus lost if active item is removed
56349cc
Fixes the user's focus being lost if the active item is destroyed while a menu is open. Fixesangular#14028.

crisbeto force-pushed the 14028/menu-item-swap-focus branch from 93fadb2 to 56349ccCompare February 27, 2022 16:19

crisbeto requested a review from a teamFebruary 27, 2022 16:19

crisbeto merged commit dc4fbcf into angular:masterFeb 27, 2022

crisbeto added a commit that referenced this pull request Feb 27, 2022
fix(material/menu): focus lost if active item is removed (#14039)
2e15f54
Fixes the user's focus being lost if the active item is destroyed while a menu is open. Fixes#14028. (cherry picked from commit dc4fbcf)

angular-automatic-lock-botBot locked and limited conversation to collaborators Mar 30, 2022

Navigation Menu

Uh oh!

fix(material/menu): focus lost if active item is removed - #14039

fix(material/menu): focus lost if active item is removed#14039
crisbeto merged 1 commit into
angular:masterfrom
crisbeto:14028/menu-item-swap-focus

crisbeto commented Nov 8, 2018

Uh oh!

crisbeto commented Nov 8, 2018

Uh oh!

ngbotBot commented Nov 27, 2018

Uh oh!

ngbotBot commented Nov 27, 2018

Uh oh!

jelbourn commented Dec 4, 2018

Uh oh!

crisbeto commented Dec 5, 2018

Uh oh!

angular-automatic-lock-botBot commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

crisbeto commented Nov 8, 2018

Uh oh!

crisbeto commented Nov 8, 2018

Uh oh!

ngbotBot commented Nov 27, 2018

Uh oh!

ngbotBot commented Nov 27, 2018

Uh oh!

jelbourn commented Dec 4, 2018

Uh oh!

crisbeto commented Dec 5, 2018

Uh oh!

angular-automatic-lock-botBot commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants