fix(material/progress-spinner): unable to change mode on spinner directive by crisbeto · Pull Request #14514 · angular/components

crisbeto · 2018-12-14T07:05:23Z

Currently we have the mat-spinner directive which is a shortcut to a mat-progress-spinner with mode="indeterminate". Since the spinner inherits all of the inputs from the progress spinner, there's nothing stoping people from changing the mode back to determinate, however the element will look half-broken because the host bindings assume that the mode won't change. These changes update the host bindings to allow switching between modes.

Fixes#14511.

jelbourn

If we're going to do this, why not just just get rid of the extra component entirely and include both selectors in one? Then set the default value for mode based on the nodeName

crisbeto · 2018-12-19T07:15:03Z

Good point. I've reworked it to only have the one class.

jelbourn

LGTM

ngbot · 2018-12-22T00:23:36Z

I see that you just added the pr: merge ready label, but the following checks are still failing:
status "ci/circleci: tests_browserstack" is failing
status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

jelbourn · 2019-05-12T15:30:49Z

@crisbeto some teams have unit tests that depend on the presence of the .mat-spinner class; could you add that back?

crisbeto · 2019-05-13T15:50:49Z

Done.

serval42 · 2019-07-26T14:44:13Z

Hello,
We had tested a mat-spinner with mode="determinate" and a value. So the progress-bar turn and have the width of the percentile of progress. We find this comportment is great.
Can we keep or formalize this 'feature' ?

…ctive Currently we have the `mat-spinner` directive which is a shortcut to a `mat-progress-spinner` with `mode="indeterminate"`. Since the spinner inherits all of the inputs from the progress spinner, there's nothing stoping people from changing the mode back to `determinate`, however the element will look half-broken because the host bindings assume that the mode won't change. These changes update the host bindings to allow switching between modes. Fixesangular#14511.

…ctive (#14514) Currently we have the `mat-spinner` directive which is a shortcut to a `mat-progress-spinner` with `mode="indeterminate"`. Since the spinner inherits all of the inputs from the progress spinner, there's nothing stoping people from changing the mode back to `determinate`, however the element will look half-broken because the host bindings assume that the mode won't change. These changes update the host bindings to allow switching between modes. Fixes#14511. (cherry picked from commit 7480e3b)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.4/13.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.4/13.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1325-satin-sash-2022-03-02) [Compare Source](angular/components@13.2.4...13.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [9e34a0f69f](angular/components@9e34a0f) | fix | **drag-drop:** error if preview dimensions are accessed too early ([#24498](angular/components#24498)) | | [9be3c46b01](angular/components@9be3c46) | fix | **testing:** TestElement sendKeys method should throw if no keys have been specified ([#18271](angular/components#18271)) | | [8e57a89cba](angular/components@8e57a89) | perf | **overlay:** add event listeners for overlay dispatchers outside of zone ([#24408](angular/components#24408)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [ed2f516401](angular/components@ed2f516) | fix | **autocomplete:** auto-highlighted first option not display correctly if the floating label is disabled ([#14507](angular/components#14507)) | | [502102116e](angular/components@5021021) | fix | **autocomplete:** don't block default arrow keys when using modifiers ([#11987](angular/components#11987)) | | [f31fd3f066](angular/components@f31fd3f) | fix | **autocomplete:** reopen panel on input click ([#16020](angular/components#16020)) | | [5a79042d7d](angular/components@5a79042) | fix | **button-toggle:** use solid border color ([#14253](angular/components#14253)) | | [e2d4eecfcb](angular/components@e2d4eec) | fix | **checkbox:** inconsistent disabled color ([#23083](angular/components#23083)) | | [005ec323de](angular/components@005ec32) | fix | **checkbox:** incorrect text color when placed inside an overlay with a dark theme ([#19054](angular/components#19054)) | | [d7cbd1315f](angular/components@d7cbd13) | fix | **datepicker:** matDatepickerParse error not being added on first invalid value ([#11524](angular/components#11524)) | | [046022f31d](angular/components@046022f) | fix | **datepicker:** use aria-live over cdkAriaLive on period button ([#24398](angular/components#24398)) | | [37f69dbf7e](angular/components@37f69db) | fix | **dialog:** use passed in ComponentFactoryResolver to resolve dialog content ([#17710](angular/components#17710)) | | [2e15f54a9f](angular/components@2e15f54) | fix | **menu:** focus lost if active item is removed ([#14039](angular/components#14039)) | | [ea07fa8e64](angular/components@ea07fa8) | fix | **progress-spinner:** unable to change mode on spinner directive ([#14514](angular/components#14514)) | | [1a498a6a81](angular/components@1a498a6) | fix | **sort:** remove role from header when disabled ([#24477](angular/components#24477)) | | [72019531db](angular/components@7201953) | fix | **tooltip:** don't hide when pointer moves to tooltip ([#24475](angular/components#24475)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [7b85cc077c](angular/components@7b85cc0) | fix | **mdc-button:** density styles being overwritten by structural styles ([#22736](angular/components#22736)) | | [aeb1426e4c](angular/components@aeb1426) | fix | **mdc-chips:** expose avatar harness ([#24499](angular/components#24499)) | #### Special Thanks Andrew Seguin, Artur Androsovych, Jeri Peier, Kristiyan Kostadinov, Paul Gschwendtner, Yousaf Nawaz and Zach Arend  </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1199 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-03-27T00:03:43Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added the target: patch This PR is targeted for the next patch release label Dec 14, 2018

crisbeto assigned josephperrott Dec 14, 2018

crisbeto requested review from jelbourn and josephperrott as code owners December 14, 2018 07:05

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2018

jelbourn reviewed Dec 19, 2018
View reviewed changes

crisbeto force-pushed the 14511/spinner-mode-override branch from c7fbb43 to 908df0eCompare December 19, 2018 07:14

crisbeto force-pushed the 14511/spinner-mode-override branch 3 times, most recently from 3eeb918 to c97bdb1Compare December 20, 2018 18:52

jelbourn approved these changes Dec 22, 2018
View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 22, 2018

crisbeto force-pushed the 14511/spinner-mode-override branch from c97bdb1 to 4084b55Compare December 25, 2018 14:18

crisbeto force-pushed the 14511/spinner-mode-override branch from 4084b55 to 23aae02Compare February 24, 2019 18:16

crisbeto force-pushed the 14511/spinner-mode-override branch 2 times, most recently from 5d30649 to 3dbcf7eCompare March 10, 2019 21:28

crisbeto force-pushed the 14511/spinner-mode-override branch from 3dbcf7e to 28d8c3fCompare April 14, 2019 17:18

mmalerba added aaa and removed aaa labels Apr 25, 2019

crisbeto force-pushed the 14511/spinner-mode-override branch from 28d8c3f to 88878b3Compare May 5, 2019 13:10

crisbeto force-pushed the 14511/spinner-mode-override branch from 88878b3 to 1370735Compare May 13, 2019 15:50

andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019

crisbeto force-pushed the 14511/spinner-mode-override branch from 1370735 to 46b0cb1Compare October 6, 2019 18:02

josephperrott removed their assignment Oct 15, 2019

crisbeto force-pushed the 14511/spinner-mode-override branch from 46b0cb1 to 26867ebCompare December 31, 2019 06:09

crisbeto force-pushed the 14511/spinner-mode-override branch from 26867eb to d73e822Compare February 7, 2020 21:54

crisbeto force-pushed the 14511/spinner-mode-override branch from d73e822 to 2a05b28Compare March 14, 2020 20:15

crisbeto force-pushed the 14511/spinner-mode-override branch from 2a05b28 to 9a97b7bCompare May 10, 2020 14:08

crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P4 A relatively minor issue that is not relevant to core functions labels Jul 25, 2020

crisbeto force-pushed the 14511/spinner-mode-override branch from 9a97b7b to 5d0698eCompare July 25, 2020 06:27

annieyw mentioned this pull request Jul 27, 2020
feat(progress-spinner): create progress-spinner based on MDC Web #20048
Merged

mmalerba removed the lgtm label Jul 31, 2020

josephperrott removed their request for review April 29, 2021 15:58

andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021

crisbeto changed the title ~~fix(progress-spinner): unable to change mode on spinner directive~~fix(material/progress-spinner): unable to change mode on spinner directiveFeb 24, 2022

crisbeto force-pushed the 14511/spinner-mode-override branch from 5d0698e to 8eb98caCompare February 24, 2022 09:01

crisbeto requested a review from a teamFebruary 24, 2022 09:01

crisbeto requested a review from andrewseguin as a code owner February 24, 2022 09:01

crisbeto removed the needs rebase label Feb 24, 2022

crisbeto force-pushed the 14511/spinner-mode-override branch from 8eb98ca to 326efe3Compare February 24, 2022 16:23

crisbeto merged commit 7480e3b into angular:masterFeb 24, 2022

angular-automatic-lock-botBot locked and limited conversation to collaborators Mar 27, 2022

Navigation Menu

Uh oh!

fix(material/progress-spinner): unable to change mode on spinner directive - #14514

fix(material/progress-spinner): unable to change mode on spinner directive#14514
crisbeto merged 1 commit into
angular:masterfrom
crisbeto:14511/spinner-mode-override

crisbeto commented Dec 14, 2018

Uh oh!

jelbourn left a comment

Uh oh!

crisbeto commented Dec 19, 2018

Uh oh!

jelbourn left a comment

Uh oh!

ngbotBot commented Dec 22, 2018

Uh oh!

jelbourn commented May 12, 2019

Uh oh!

crisbeto commented May 13, 2019

Uh oh!

serval42 commented Jul 26, 2019

Uh oh!

angular-automatic-lock-botBot commented Mar 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

crisbeto commented Dec 14, 2018

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

crisbeto commented Dec 19, 2018

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

ngbotBot commented Dec 22, 2018

Uh oh!

jelbourn commented May 12, 2019

Uh oh!

crisbeto commented May 13, 2019

Uh oh!

serval42 commented Jul 26, 2019

Uh oh!

angular-automatic-lock-botBot commented Mar 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants