Uh oh!
There was an error while loading. Please reload this page.
fix(menu): reduce specificity of icon selector - #14389
Merged
Merged
Conversation
In angular#14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
mmalerba added a commit
that referenced
this pull request
Dec 5, 2018
…correctly if the floating label is disabled" (#14396) * Revert "fix(drag-drop): error on touch end (#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)" This reverts commit c99c512.
mmalerba added a commit
that referenced
this pull request
Dec 5, 2018
… in trigger" (#14398) * Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)" This reverts commit aa17fbd. * Revert "fix(drag-drop): error on touch end (#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)" This reverts commit c99c512. * Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)" This reverts commit 904a5ea.
mmalerba pushed a commit
that referenced
this pull request
Dec 10, 2018
In #14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
mmalerba added a commit
that referenced
this pull request
Dec 10, 2018
…correctly if the floating label is disabled" (#14396) * Revert "fix(drag-drop): error on touch end (#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)" This reverts commit c99c512.
mmalerba added a commit
that referenced
this pull request
Dec 10, 2018
… in trigger" (#14398) * Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)" This reverts commit aa17fbd. * Revert "fix(drag-drop): error on touch end (#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)" This reverts commit c99c512. * Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)" This reverts commit 904a5ea.
josephperrott pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
In angular#14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
josephperrott pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…correctly if the floating label is disabled" (angular#14396) * Revert "fix(drag-drop): error on touch end (angular#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (angular#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (angular#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#13774)" This reverts commit c99c512.
josephperrott pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
… in trigger" (angular#14398) * Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (angular#14396)" This reverts commit aa17fbd. * Revert "fix(drag-drop): error on touch end (angular#14392)" This reverts commit 53cecbb. * Revert "fix(menu): reduce specificity of icon selector (angular#14389)" This reverts commit 74e945a. * Revert "fix(drag-drop): throw better error when attaching to non-element node (angular#14221)" This reverts commit 31f0e6d. * Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#13774)" This reverts commit c99c512. * Revert "fix(autocomplete): update template when changing autocomplete in trigger (angular#13814)" This reverts commit 904a5ea.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #14161 we had to tweak the selector for an icon inside a
mat-menu-item, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.