Skip to content

fix(drag-drop): error on touch end - #14392

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:14390/drag-touchend-error
Dec 5, 2018
Merged

fix(drag-drop): error on touch end#14392
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:14390/drag-touchend-error

Conversation

@crisbeto

@crisbetocrisbeto commented Dec 5, 2018

Copy link
Copy Markdown
Member

Fixes an error being thrown by CdkDrag when the touchend event fires.

Fixes#14390.

Marking as P2 since this will throw consistently on touch devices.

@crisbetocrisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 5, 2018
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2018
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 5, 2018
@crisbeto
fix(drag-drop): error on touch end
3cdc230
Fixes an error being thrown by `CdkDrag` when the `touchend` event fires.
Fixesangular#14390.
@crisbeto
crisbetoforce-pushed the 14390/drag-touchend-error branch from 65eda94 to 3cdc230CompareDecember 5, 2018 21:04
@mmalerba
mmalerba merged commit 53cecbb into angular:masterDec 5, 2018
mmalerba added a commit that referenced this pull request Dec 5, 2018
@mmalerba
Revert "fix(drag-drop): error on touch end (#14392)"
82105a2
This reverts commit 53cecbb.
mmalerba added a commit that referenced this pull request Dec 5, 2018
@mmalerba
Revert "fix(autocomplete): auto-highlighted first option not display …
aa17fbd
…correctly if the floating label is disabled" (#14396)
* Revert "fix(drag-drop): error on touch end (#14392)"
This reverts commit 53cecbb.
* Revert "fix(menu): reduce specificity of icon selector (#14389)"
This reverts commit 74e945a.
* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"
This reverts commit 31f0e6d.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"
This reverts commit c99c512.
mmalerba added a commit that referenced this pull request Dec 5, 2018
@mmalerba
Revert "fix(drag-drop): error on touch end (#14392)"
3e91714
This reverts commit 53cecbb.
mmalerba added a commit that referenced this pull request Dec 5, 2018
@mmalerba
Revert "fix(autocomplete): update template when changing autocomplete…
63be232
… in trigger" (#14398)
* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"
This reverts commit aa17fbd.
* Revert "fix(drag-drop): error on touch end (#14392)"
This reverts commit 53cecbb.
* Revert "fix(menu): reduce specificity of icon selector (#14389)"
This reverts commit 74e945a.
* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"
This reverts commit 31f0e6d.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"
This reverts commit c99c512.
* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"
This reverts commit 904a5ea.
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
@crisbeto@mmalerba
fix(drag-drop): error on touch end (#14392)
68a5f35
Fixes an error being thrown by `CdkDrag` when the `touchend` event fires.
Fixes#14390.
Marking as P2 since this will throw consistently on touch devices.
mmalerba added a commit that referenced this pull request Dec 10, 2018
@mmalerba
Revert "fix(autocomplete): auto-highlighted first option not display …
753eae5
…correctly if the floating label is disabled" (#14396)
* Revert "fix(drag-drop): error on touch end (#14392)"
This reverts commit 53cecbb.
* Revert "fix(menu): reduce specificity of icon selector (#14389)"
This reverts commit 74e945a.
* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"
This reverts commit 31f0e6d.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"
This reverts commit c99c512.
mmalerba added a commit that referenced this pull request Dec 10, 2018
@mmalerba
Revert "fix(autocomplete): update template when changing autocomplete…
733c8ee
… in trigger" (#14398)
* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"
This reverts commit aa17fbd.
* Revert "fix(drag-drop): error on touch end (#14392)"
This reverts commit 53cecbb.
* Revert "fix(menu): reduce specificity of icon selector (#14389)"
This reverts commit 74e945a.
* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"
This reverts commit 31f0e6d.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"
This reverts commit c99c512.
* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"
This reverts commit 904a5ea.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto@josephperrott
fix(drag-drop): error on touch end (angular#14392)
b6a4dda
Fixes an error being thrown by `CdkDrag` when the `touchend` event fires.
Fixesangular#14390.
Marking as P2 since this will throw consistently on touch devices.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@mmalerba@josephperrott
Revert "fix(autocomplete): auto-highlighted first option not display …
6d38ca1
…correctly if the floating label is disabled" (angular#14396)
* Revert "fix(drag-drop): error on touch end (angular#14392)"
This reverts commit 53cecbb.
* Revert "fix(menu): reduce specificity of icon selector (angular#14389)"
This reverts commit 74e945a.
* Revert "fix(drag-drop): throw better error when attaching to non-element node (angular#14221)"
This reverts commit 31f0e6d.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#13774)"
This reverts commit c99c512.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@mmalerba@josephperrott
Revert "fix(autocomplete): update template when changing autocomplete…
4b8d6f9
… in trigger" (angular#14398)
* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (angular#14396)"
This reverts commit aa17fbd.
* Revert "fix(drag-drop): error on touch end (angular#14392)"
This reverts commit 53cecbb.
* Revert "fix(menu): reduce specificity of icon selector (angular#14389)"
This reverts commit 74e945a.
* Revert "fix(drag-drop): throw better error when attaching to non-element node (angular#14221)"
This reverts commit 31f0e6d.
* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#13774)"
This reverts commit c99c512.
* Revert "fix(autocomplete): update template when changing autocomplete in trigger (angular#13814)"
This reverts commit 904a5ea.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jelbournjelbourn

@mmalerbammalerba

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaroundtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdkDropList broken on touch devices on touchend

4 participants

@crisbeto@jelbourn@googlebot@mmalerba