Uh oh!
There was an error while loading. Please reload this page.
refactor(stepper): rework buttons to handle Ivy - #15429
Merged
Merged
Conversation
In Ivy inheriting `host` bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the `click` listener on the buttons will be invoked twice with Ivy. These changes rework the buttons so that they work both with Ivy and ViewEngine.
crisbetoforce-pushed
the
stepper-ivy-support
branch
from
March 10, 2019 08:01
1ff119d to
8ff3bb1Comparemmalerba
approved these changes
Mar 11, 2019
mmalerba
left a comment
Contributor
There was a problem hiding this comment.
Cool, looks like some fixes for weird provider stuff that was happening too
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Mar 13, 2019
In Ivy inheriting `host` bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the `click` listener on the buttons will be invoked twice with Ivy. These changes rework the buttons so that they work both with Ivy and ViewEngine.
mmalerba pushed a commit
that referenced
this pull request
Mar 13, 2019
In Ivy inheriting `host` bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the `click` listener on the buttons will be invoked twice with Ivy. These changes rework the buttons so that they work both with Ivy and ViewEngine.
Suresh918 pushed a commit
to Suresh918/material2
that referenced
this pull request
Apr 15, 2019
In Ivy inheriting `host` bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the `click` listener on the buttons will be invoked twice with Ivy. These changes rework the buttons so that they work both with Ivy and ViewEngine.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ivy inheriting
hostbindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup theclicklistener on the buttons will be invoked twice with Ivy.These changes rework the buttons so that they work both with Ivy and ViewEngine.