Skip to content

refactor(stepper): rework buttons to handle Ivy (#15429) - #15463

Merged
mmalerba merged 1 commit into
angular:ivy-2019from
crisbeto:ivy-2019-stepper-buttons
Mar 13, 2019
Merged

refactor(stepper): rework buttons to handle Ivy (#15429)#15463
mmalerba merged 1 commit into
angular:ivy-2019from
crisbeto:ivy-2019-stepper-buttons

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Equivalent of #15429 for the Ivy branch.

In Ivy inheriting host bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the click listener on the buttons will be invoked twice with Ivy.

These changes rework the buttons so that they work both with Ivy and ViewEngine.

In Ivy inheriting `host` bindings works correctly by merging the two declarations, whereas in ViewEngine the bindings aren't inherited at all. This means that with our current setup the `click` listener on the buttons will be invoked twice with Ivy.
These changes rework the buttons so that they work both with Ivy and ViewEngine.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@crisbetocrisbeto added the P2 The issue is important to a large percentage of users, with a workaround label Mar 13, 2019
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2019
@ngbot

ngbotBot commented Mar 13, 2019

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "ci/circleci: api_golden_checks" is failing
failure status "ci/circleci: bazel_build_test" is failing
failure status "ci/circleci: build_release_packages" is failing
failure status "ci/circleci: e2e_tests" is failing
failure status "ci/circleci: lint" is failing
failure status "ci/circleci: prerender_build" is failing
failure status "ci/circleci: tests_browserstack" is failing
failure status "ci/circleci: tests_local_browsers" is failing
failure status "ci/circleci: tests_saucelabs" is failing
pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
mmalerba merged commit 22be0d8 into angular:ivy-2019Mar 13, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaround

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto@googlebot@mmalerba